🚀 go-pugleaf

RetroBBS NetNews Server

Inspired by RockSolid Light RIP Retro Guy

Article View: gnu.emacs.bug
Article #88095

19.21 font-lock.el bug

#88095
From: garyo
Date: Wed, 10 Aug 1994 04:32
34 lines
1928 bytes
In GNU Emacs 19.21.1 of Thu Nov 18 1993 on caffeine (usg-unix-v)

Line 312 or so of font-lock.el looks like this:
		      (let ((next (next-single-property-change (point) 'face)))
			(if (> next (point-max))
			    (setq next (point-max)))
			...
Unfortunately next-single-property-change returns nil, not > (point-max) 
if there are no more property changes.  So the failure test is
incorrect.  See patch below, which modifies it to test for null first.

-- Gary Oberbrunner (garyo@avs.com)

diff -c font-lock.el.~1~ font-lock.el
*** font-lock.el.~1~	Tue Nov 16 07:15:12 1993
--- font-lock.el	Tue Aug  9 15:13:23 1994
***************
*** 310,316 ****
  		    (narrow-to-region s e)
  		    (while (not (eobp))
  		      (let ((next (next-single-property-change (point) 'face)))
! 			(if (> next (point-max))
  			    (setq next (point-max)))
  			(if (not (get-text-property (point) 'face))
  			    (put-text-property (point) next 'face face))
--- 310,317 ----
  		    (narrow-to-region s e)
  		    (while (not (eobp))
  		      (let ((next (next-single-property-change (point) 'face)))
! 			(if (or (null next)
! 				(> next (point-max)))
  			    (setq next (point-max)))
  			(if (not (get-text-property (point) 'face))
  			    (put-text-property (point) next 'face face))
Technical Details
Message-ID: <9408091921.AA18456@prometheus>
Path: arc1-ca.pugleaf.net!bga.com!news.sprintlink.net!qns1.qns.com!constellation!convex!convex!cs.utexas.edu!math.ohio-state.edu!cis.ohio-state.edu!avs.com!garyo

Show Full Headers
Complete Article Headers
X-Google-Language: ENGLISH,ASCII-7-bit
X-Google-Thread: fb2f1,196fbbcb439ea5bc,start
X-Google-Attributes: gidfb2f1,public
X-Google-ArrivalTime: 1994-08-10 12:15:48 PST
Path: arc1-ca.pugleaf.net!bga.com!news.sprintlink.net!qns1.qns.com!constellation!convex!convex!cs.utexas.edu!math.ohio-state.edu!cis.ohio-state.edu!avs.com!garyo
From: garyo@avs.com
Newsgroups: gnu.emacs.bug
Subject: 19.21 font-lock.el bug
Date: 10 Aug 1994 00:32:43 -0400
Organization: GNUs Not Usenet
Lines: 35
Sender: daemon@cis.ohio-state.edu
Approved: bug-gnu-emacs@prep.ai.mit.edu
Distribution: gnu
Message-ID: <9408091921.AA18456@prometheus>