Article View: gnu.emacs.bug
Article #98800mail-send-and-exit still broken in 18.57
From: "Barr3y Jaspan"
Date: Fri, 01 Mar 1991 21:22
Date: Fri, 01 Mar 1991 21:22
40 lines
1955 bytes
1955 bytes
(emacs-version)
"GNU Emacs 18.57.8 of Fri Feb 22 1991 on pit-manager (berkeley-unix)"
mail-send-and-exit in sendmail.el still checks if the next window is
in rmail-mode before deleting it. This is a bug according to the help
information for the function and is also completely silly; there's no
reason for rmail-mode to be treated specially. (Also, applying
DeMorgan's Theorem results in more efficient code here.) Patch:
*** /mit/emacs/emacs-18.57/lisp/sendmail.el Wed Jan 9 17:04:09 1991
--- /tmp/sendmail.el Fri Mar 1 16:19:22 1991
***************
*** 152,164 ****
(interactive "P")
(mail-send)
(bury-buffer (current-buffer))
! (if (and (not arg)
! (not (one-window-p))
! (save-excursion
! (set-buffer (window-buffer (next-window (selected-window) 'not)))
! (eq major-mode 'rmail-mode)))
! (delete-window)
! (switch-to-buffer (other-buffer (current-buffer)))))
(defun mail-send ()
"Send the message in the current buffer.
--- 152,160 ----
(interactive "P")
(mail-send)
(bury-buffer (current-buffer))
! (if (or arg (one-window-p))
! (switch-to-buffer (other-buffer (current-buffer)))
! (delete-window)))
(defun mail-send ()
"Send the message in the current buffer.
--
Barr3y Jaspan, bjaspan@mit.edu
Watchmaker Computing
Technical Details
Message-ID:
<9103012122.AA24578@steve-dallas.MIT.EDU>Path:
arc1-ca.pugleaf.net!gmdzi!unido!mcsun!uunet!tut.cis.ohio-state.edu!unreplyable!garbageShow Full Headers
Complete Article Headers
X-Google-Language: ENGLISH,ASCII-7-bit
X-Google-Thread: fb2f1,7ef263db619810e9,start
X-Google-Attributes: gidfb2f1,public
X-Google-ArrivalTime: 1991-03-02 02:24:03 PST
Path: arc1-ca.pugleaf.net!gmdzi!unido!mcsun!uunet!tut.cis.ohio-state.edu!unreplyable!garbage
From: bjaspan@ATHENA.MIT.EDU ("Barr3y Jaspan")
Newsgroups: gnu.emacs.bug
Subject: mail-send-and-exit still broken in 18.57
Message-ID: <9103012122.AA24578@steve-dallas.MIT.EDU>
Date: 1 Mar 91 21:22:46 GMT
Sender: daemon@tut.cis.ohio-state.edu
Distribution: gnu
Organization: GNUs Not Usenet
Lines: 40
Approved: bug-gnu-emacs@prep.ai.mit.edu