🚀 go-pugleaf

	Me> I've noticed a change in the way emacs interacts with R4 twm.
	Me> In particular, when getting and giving up focus, the block
	Me> cursor will not always change color correctly.

Okay, here's some more details on the problem. For the record:

Emacs 18.57
Sun SS1+, SunOS 4.1
MIT X11R4.18 Server w/ X11R4.18 TWM window manager

Under this configuration, using the mouse to move the cursor into and
out of the emacs window works fine. Moving the mouse into the window
generates an EnterNotify event, but no FocusIn event. Moving the mouse
out of the window generates a LeaveNotify event but no FocusOut event.
The problem comes when using a twm command such as f.warpring to move
into or out of the window.

To recreate the problem, put the following in your .twmrc file (at the
appropriate place):

#NoRaiseOnWarp (i.e. you want raise-on-warp)
WindowRing { "Emacs" "XTerm" }
"n" = s|c      	: all   	: f.warpring "next"
"p" = s|c      	: all   	: f.warpring "prev"

The effect of these is that you should be able to warp the cursor
between all your mapped xterm and emacs windows just by hitting
ctrl-shift-n and ctrl-shift-p. First, make the above modifications to
your .twmrc file and restart twm. Then bring up two emacs windows and
an xterm window.  Put the cursor (using the mouse) in an 18.57 emacs
window, then hit ctrl-shift-n.  One of the other emacs/xterm windows
should be raised, and the cursor will move into that window, but the
cursor-block of the original emacs window should remain solid. The
reason for this is that the emacs window will receive the following 5
X events during the execution of f.warpring "next":

	1. FocusOut
	2. FocusIn
	3. FocusOut
	4. FocusIn
	5. LeaveNotify

At this point, hitting ctrl-shift-p warps the cursor back to the emacs
window, but no Focus* events are generated. I don't know why these
events in this order are sent to the emacs window when warping out of
or into the window, however, looking at the code in x11term.c, its
pretty clear why this sequence of events will mess up emacs'
cursor-block (and why 18.55 did not exhibit the same problem).  I
don't know if this is a twm problem, but I'm planning to cross post
this message to comp.windows.x to see if anyone has any further
information.  Also note that doing the same thing to the xterm window
does not mess up its cursor block. This is because xterm ignores the
Focus(In/Out) events and just toggles its cursor solidness on
(Enter/Leave)Notify events (see xterm's misc.c file).

So anyway, the patch below changes emacs so that it will also ignore
Focus(In/Out) events and just toggle the cursor on (Enter/Leave)Notify
events.  Whether this behavior is "correct" or not according to ICCCM,
I can't say.  But emacs' cursor now seems to behave properly when
entering or leaving the window using either f.warpring or the mouse.

I'd be interested in hearing from other twm users who cannot recreate
the problem by following the steps I outline above. I suppose it is
possible that some thing else in my .twmrc file or my general X
environment is affecting this behavior...

-Barry

NAME:  Barry A. Warsaw         INET: warsaw@nlm.nih.gov
TELE:  (301) 496-1936          UUCP: uunet!nlm.nih.gov!warsaw

*** x11term.c.orig	Mon Mar  4 16:24:13 1991
--- x11term.c	Mon Mar  4 16:24:30 1991
***************
*** 1377,1400 ****
        break;
  
-     case FocusIn:
-       x_focus_flag = 1;
      case EnterNotify:
-       if (event.type == FocusIn || (!x_focus_flag && event.xcrossing.focus))
- 	{
  	  CursorToggle ();
  	  CursorOutline = 0;
  	  CursorToggle ();
- 	}
        break;
  
-     case FocusOut:
-       x_focus_flag = 0;
      case LeaveNotify:
-       if (event.type == FocusOut || (!x_focus_flag && event.xcrossing.focus))
- 	{
  	  CursorToggle ();
  	  CursorOutline = 1;
  	  CursorToggle ();
- 	}
        break;
  			
--- 1377,1390 ----