🚀 go-pugleaf

RetroBBS NetNews Server

Inspired by RockSolid Light RIP Retro Guy

Article View: gnu.emacs.bug
Article #98860

Bug in new makeinfo.c program

#98860
From: Tom Horsley
Date: Thu, 21 Feb 1991 16:27
38 lines
2558 bytes
Here is a patch to the makeinfo.c that appeared in the texinfo2.tar.Z file
on prep.ai.mit.edu recently. This avoids indirecting through a NULL pointer,
which causes SIGSEVs in programs built on a DG AviioN (unless you twiddle
the way the defaults for the linker work).

"makeinfo +version" reports the version number as 1.0, so I wonder about the
accuracy of the version number as well.

*** makeinfo.c.orig	Wed Feb 20 11:33:48 1991
--- makeinfo.c	Thu Feb 21 11:17:31 1991
***************
*** 4845,4851 ****
       a simple @@ followed immediately by more text.  If this is the case,
       then the next defun arg is part of this one, and we should concatenate
       them. */
!   if (**scan_args && !whitespace (**scan_args) &&
        (strcmp (defined_name, "@@") == 0))
      {
        char *tem = (char *)xmalloc (3 + strlen (scan_args[0]));
--- 4845,4851 ----
       a simple @@ followed immediately by more text.  If this is the case,
       then the next defun arg is part of this one, and we should concatenate
       them. */
!   if (*scan_args && **scan_args && !whitespace (**scan_args) &&
        (strcmp (defined_name, "@@") == 0))
      {
        char *tem = (char *)xmalloc (3 + strlen (scan_args[0]));

This particular bug crops up attempting to run makeinfo on the texinfo2.texi
file that comes in the same package with the makeinfo.c program.
--
======================================================================
domain: tahorsley@csd.harris.com       USMail: Tom Horsley
  uucp: ...!uunet!hcx1!tahorsley               511 Kingbird Circle
                                               Delray Beach, FL  33444
+==== Censorship is the only form of Obscenity ======================+
|     (Wait, I forgot government tobacco subsidies...)               |
+====================================================================+
Technical Details
Message-ID: <TOM.91Feb21112747@hcx2.ssd.csd.harris.com>
Path: arc1-ca.pugleaf.net!gmdzi!unido!fauern!ira.uka.de!sol.ctr.columbia.edu!spool.mu.edu!sdd.hp.com!usc!rutgers!tut.cis.ohio-state.edu!unreplyable!garbage

Show Full Headers
Complete Article Headers
X-Google-Language: ENGLISH,ASCII-7-bit
X-Google-Thread: fb2f1,7f304f37f22a7e61,start
X-Google-Attributes: gidfb2f1,public
X-Google-ArrivalTime: 1991-02-21 08:27:47 PST
Path: arc1-ca.pugleaf.net!gmdzi!unido!fauern!ira.uka.de!sol.ctr.columbia.edu!spool.mu.edu!sdd.hp.com!usc!rutgers!tut.cis.ohio-state.edu!unreplyable!garbage
From: tom@TRAVIS.SSD.CSD.HARRIS.COM (Tom Horsley)
Newsgroups: gnu.emacs.bug
Subject: Bug in new makeinfo.c program
Message-ID: <TOM.91Feb21112747@hcx2.ssd.csd.harris.com>
Date: 21 Feb 91 16:27:47 GMT
Sender: daemon@tut.cis.ohio-state.edu
Distribution: gnu
Organization: Harris Computer Systems Division
Lines: 38
Approved: bug-gnu-emacs@prep.ai.mit.edu