Article View: gnu.emacs.bug
Article #98874Bug in rmailout.el
From: Sebastian Kremer
Date: Thu, 24 Jan 1991 23:26
Date: Thu, 24 Jan 1991 23:26
37 lines
2028 bytes
2028 bytes
GNUS bombed (wrong-type-argument stringp nil) when I tried to save an
article without a "From" field (don't ask me why our local news
groups don't have from fields). I traced it down to rmailout.el
calling mail-strip-quoted-names with a nil argument. The code wants
to handle the case of a missing from field, but actually fails to do
so.
You could argue that mail-strip-quoted-names from mail-utils.el is
wrong in bombing on a nil argument. Anyway, rmailout was easier to
fix.
diff -c2 /vol/gnu/emacs/lisp/ /vol/gnu/emacs/lisp/local/rmailout.el
*** /vol/gnu/emacs/lisp//rmailout.el Thu Apr 14 12:36:10 1988
--- /vol/gnu/emacs/lisp/local/rmailout.el Thu Jan 24 18:13:43 1991
***************
*** 109,113 ****
(goto-char (point-min))
(insert "From "
! (or (mail-strip-quoted-names (mail-fetch-field "from"))
"unknown")
" " (current-time-string) "\n")
--- 109,117 ----
(goto-char (point-min))
(insert "From "
! (or (if (mail-fetch-field "from")
! ;; must not pass nil to mail-strip-quoted-names!
! ;; sk@sun0 24-Jan-1991 18:13
! (mail-strip-quoted-names (mail-fetch-field "from"))
! nil)
"unknown")
" " (current-time-string) "\n")
--
Sebastian Kremer <sk@thp.Uni-Koeln.DE>
Institute of Theoretical Physics, University of Cologne, F. R. of Germany
Technical Details
Message-ID:
<SK.91Jan24182655@sun0.thp.uni-koeln.de>Path:
arc1-ca.pugleaf.net!gmdzi!unido!mcsun!uunet!tut.cis.ohio-state.edu!thp.uni-koeln.de!skShow Full Headers
Complete Article Headers
X-Google-Language: ENGLISH,ASCII-7-bit X-Google-Thread: fb2f1,8204e96d924a80b5,start X-Google-Attributes: gidfb2f1,public X-Google-ArrivalTime: 1991-01-24 15:26:55 PST Path: arc1-ca.pugleaf.net!gmdzi!unido!mcsun!uunet!tut.cis.ohio-state.edu!thp.uni-koeln.de!sk From: sk@thp.uni-koeln.de (Sebastian Kremer) Newsgroups: gnu.emacs.bug Subject: Bug in rmailout.el Message-ID: <SK.91Jan24182655@sun0.thp.uni-koeln.de> Date: 24 Jan 91 23:26:55 GMT Sender: daemon@tut.cis.ohio-state.edu Distribution: gnu Organization: Institute of Theoretical Physics, University of Cologne, F. R. Germany Lines: 37 Approved: bug-gnu-emacs@prep.ai.mit.edu