🚀 go-pugleaf

Today, I made my first ever personal code modification to the emacs
source.  I wanted csh-like cdpath functionality from the 'cd function.
Implementing this required changing the openp() routine in lread.c.
While studying the unmodified source, I discovered what I believe to
be a bug:

              /* Check that we can access or open it.  */
              if (exec_only)
                fd = !access (fn, X_OK);
              else
                fd = open (fn, 0, 0);

              if (fd >= 0)
                {
                  /* We succeeded; return this descriptor and filename.  */
                  if (storeptr)
                    *storeptr = build_string (fn);
                  return fd;
                }

The access() function returns 0 or -1.  So (fd >= 0) will always
evaluate to be true which means openp() will always return success.
I believe:

		fd = access (fn, X_OK);

is what was intended.

-- 
William Bailey
Oracle Corp.
400 Oracle Parkway
Redwood City CA 94065