🚀 go-pugleaf

A coworker and I just discovered a bug in ftp-write-file in ftp.el.
In particular, calling ftp-write-file causes the second buffer in the
buffer list to mysteriously become read only.  The actual problem is
in the function ftp-setup-buffer which does a (setq buffer-read-only
t).  I don't understand enough about emacs lisp to understand where
buffer-read-only is coming from but the wrong one is getting bashed.
I have verified the bug on three different versions of emacs (18.50,
18.54, and 18.55).

To reproduce:
1) start up emacs
2) load a file (say your .emacs file)
3) C-x C-b (list-buffers to show that nothing is currently read-only)
4) M-x ftp-write-file
5) Give a new file name.  Even <local-host>:/tmp/junk works!
6) Give the password.  Wait for the write to complete.
7) C-x C-b and suddenly your *scratch* buffer is read only!

The simplest partial fix we found was to comment out the (setq
buffer-read-only t) from ftp-setup-buffer.  This has the problem that
if the second buffer happens to actually be read-only then it is made
writable.  It would be wonderful if someone would figure out what's
really happening and fix it.

Nathan Wilson
Teleos Research
nathan%teleos.com@ai.sri.com