🚀 go-pugleaf

Here are a few bugs I found reading the source to Emacs 18.55.
Let's just say I don't think any aircraft are going to crash because
of these bugs, but I thought I'd mention them.

------

In make-local-variable, the function returns immediately if the variable
has already been made "automatically buffer-local", i.e., by
make-variable-buffer-local.  This is almost right, but there is a
window between the call to make-local-variable and the first setq in
which a setq-default's effect is incorrectly visible.

	(setq foo 'one)
	(make-variable-buffer-local 'foo)
	(make-local-variable 'foo)
	foo  => 'one
	(setq-default foo 'two)
	foo  => 'two    [this is inconsistent]
	(setq foo 'three)
	foo  => 'three
	(setq-default foo 'four)
	foo  => 'three  [correct behavior]

------

The aset function doesn't check the type of the argument to be stored
in a string.  Hey, kids, here's your chance to probe the inner workings
of Emacs pointers!

	(setq foo (make-string 5 ?A))  => "AAAAA"
	(aset foo 2 'not-an-integer)
	foo  => "AAdAA"

------

The function string-to-int is coded and documented as having an optional
second parameter, but max_args is set to 1 so that this argument cannot
be used.

								-- Dave