🚀 go-pugleaf

RetroBBS NetNews Server

Inspired by RockSolid Light RIP Retro Guy

Article View: gnu.emacs.bug
Article #99975

18.55 emacs does X focus management wrong

#99975
From: Jonathan I. Kamens
Date: Thu, 15 Feb 1990 06:42
77 lines
2784 bytes
  Emacs 18.55 uses EnterWindow and LeaveWindow events to decide when
to solidify and outline the cursor.  Instead, it should use FocusIn
and FocusOut events; the change to make it do this is trivial.  Patch
follows at the end of this message.

Jonathan Kamens			              USnail:
MIT Project Athena				11 Ashford Terrace
jik@Athena.MIT.EDU				Allston, MA  02134
Office: 617-253-8495			      Home: 617-782-0710

*** /tmp/,RCSt1022884	Thu Feb 15 01:40:46 1990
--- x11term.c	Thu Feb 15 01:40:16 1990
***************
*** 1307,1331 ****
  
      case NoExpose:
        break;
! 			
!       /*
!        * NOTE: No 'Focus' management is being done yet. If
!        * some other window has grabbed the focus, emacs will
!        * still show a filled cursor whenever the pointer
!        * enters the emacs window.
!        */
!     case EnterNotify:
        CursorToggle ();
        CursorOutline = 0;
        CursorToggle ();
        break;
  
!     case LeaveNotify:
        CursorToggle ();
        CursorOutline = 1;
        CursorToggle ();
        break;
! 			
      case KeyPress:
        nbytes = XLookupString (&event,
  			      mapping_buf, 20, &keysym,
--- 1307,1325 ----
  
      case NoExpose:
        break;
! 
!     case FocusIn:
        CursorToggle ();
        CursorOutline = 0;
        CursorToggle ();
        break;
  
!     case FocusOut:
        CursorToggle ();
        CursorOutline = 1;
        CursorToggle ();
        break;
! 
      case KeyPress:
        nbytes = XLookupString (&event,
  			      mapping_buf, 20, &keysym,
***************
*** 2386,2392 ****
  
      XSelectInput(XXdisplay, XXwindow, KeyPressMask |
  		 ExposureMask | ButtonPressMask | ButtonReleaseMask |
! 		 EnterWindowMask | LeaveWindowMask |
  		 StructureNotifyMask);
  
      XMapWindow (XXdisplay, XXwindow);
--- 2380,2386 ----
  
      XSelectInput(XXdisplay, XXwindow, KeyPressMask |
  		 ExposureMask | ButtonPressMask | ButtonReleaseMask |
! 		 FocusChangeMask |
  		 StructureNotifyMask);
  
      XMapWindow (XXdisplay, XXwindow);
Technical Details
Message-ID: <9002150642.AA22892@pit-manager.MIT.EDU>
Path: arc1-ca.pugleaf.net!gmdzi!unido!mcsun!uunet!bu.edu!lll-winken!brutus.cs.uiuc.edu!zaphod.mps.ohio-state.edu!tut.cis.ohio-state.edu!PIT-MANAGER.MIT.EDU!jik

Show Full Headers
Complete Article Headers
X-Google-Language: ENGLISH,ASCII-7-bit
X-Google-Thread: fb2f1,1d0043a2360e5d8f,start
X-Google-Attributes: gidfb2f1,public
X-Google-ArrivalTime: 1990-02-15 15:32:07 PST
Path: arc1-ca.pugleaf.net!gmdzi!unido!mcsun!uunet!bu.edu!lll-winken!brutus.cs.uiuc.edu!zaphod.mps.ohio-state.edu!tut.cis.ohio-state.edu!PIT-MANAGER.MIT.EDU!jik
From: jik@PIT-MANAGER.MIT.EDU (Jonathan I. Kamens)
Newsgroups: gnu.emacs.bug
Subject: 18.55 emacs does X focus management wrong
Message-ID: <9002150642.AA22892@pit-manager.MIT.EDU>
Date: 15 Feb 90 06:42:05 GMT
Sender: daemon@tut.cis.ohio-state.edu
Distribution: gnu
Organization: GNUs Not Usenet
Lines: 77
Posted: Thu Feb 15 07:42:05 1990