🚀 go-pugleaf

Uday S Reddy <uDOTsDOTreddy@cs.bham.ac.uk> writes:
> Sorry, JJK.  I find this rather convoluted.  
Personally, I think my way of doing it is "clever" ;) since:
   - No new variables need to be used or learned
   - vm-pipe-message-part is extended in a transparent fashion so the
     added functionality can be used in other commands as needed
     (Also, my extension allows for retrieving headers, bodies, messages 
     each with or without the separator and without having to set a
     variable)
   - The changes to vm-pipe-messages-to-command are done cleanly without
     really even modifying any lines of existing code. It just
     changes/resets the value of 3 variables. In fact the change is so
     simple, it could be implemented with just a simple piece of around
     advice.


> I have already added yesterday a variable called
> `vm-message-include-separators' to alter the meaning of what a
> "message" means.  All that is needed now is to call
> vm-pipe-message-to-command after setting this variable to t.

OK. What happens to the variables vm-pipe-messages-to-command-start/end
when your variable is set to 't'? 

Note that by default vm-pipe-messages-to-command-end is set to "\n", so
if it is still used then you will be inserting an extra newline between
messages. 

If you don't automatically do something about it, then you have to
remember to set both variables to "" when you set
vm-message-include-separators=t or else you will have an extra newline
or other info inserted. This would not be a good idea since in addition
to being confusing, every time you want to "toggle" on/off this
functionality, you would now need to change (and potentially store) the
value 3 variables.

>
> In fact, it would seem to make sense for vm-pipe-message-to-command to
> do this automatically whenever it is dealing with multiple
> messages. (I can't imagine why one would want a sequence of messages
> without any separators between them. 
I could definitely imagine many cases:
1. If you want to grep for something in message bodies, you don't want
   the From_ separator (or even extra blank newlines)
2. Similarly if you just want to do something on the collection of all
   RFC headers (e.g., grep for all messages with something in the
   header), you  don't want the From_ line
3. If you are trying to know the exact total length of all the messges,
   again you don't want separators...
etc...

> But, anyway, I won't split hairs
> about that!)
>
> This will be in 8.1.1-devo version in a few minutes.
Thanks. Have you also included my bug fixes to:
     vm-pipe-command-exit-handler
     vm-pipe-messages-to-command