Article View: gnu.emacs.vm.bug
Article #238Re: Suggested fix to vm-pipe-message-part
From: blueman
Date: Thu, 07 Jan 2010 16:15
Date: Thu, 07 Jan 2010 16:15
44 lines
3518 bytes
3518 bytes
Uday S Reddy <uDOTsDOTreddy@cs.bham.ac.uk> writes: > blueman wrote: > >>> >> Please try with the two patches I submitted. > > Hi, I don't know what you mean by "submitted". I haven't yet received > anything from you via launchpad.net. > > Whatever you posted here has been put in. But in your version of the > exit-handler below, notice that you added a 'command' argument but > never used it! Sure it is used: >> (funcall exit-handler command buffer)))) Plus, even if it weren't used, it still would create a problem since the function vm-pipe-command-exit-handler is called with 'command' placed in the second position. Again, I am quite positive that it works fine with my edits. If you can't get it working, send me some debug traces and/or sample code and I will try to help figure out why it is not working on your setup. > > >> --------------------------------------------------------------------- >> >> ; Fixes missing 'command' argument in defun >> (defun vm-pipe-command-exit-handler (process command discard-output >> &optional exit-handler) >> "Switch to output buffer of PROCESS if DISCARD-OUTPUT non-nil. >> If non-nil call EXIT-HANDLER with the two arguments COMMAND and >> OUTPUT-BUFFER." (let ((exit-code (process-exit-status process)) >> (buffer (process-buffer process)) >> (command (process-command process))) >> (if (not (zerop exit-code)) >> (message "Command '%s' exit code is %d." command exit-code)) >> (vm-display nil nil '(vm-pipe-message-to-command) >> '(vm-pipe-message-to-command)) >> (vm-switch-to-command-output-buffer command buffer discard-output) >> (if exit-handler >> (funcall exit-handler command buffer)))) >>
Technical Details
Message-ID:
<m24omxzybc.fsf@consult.pretender>Path:
arc1-ca.pugleaf.net!g2news1.google.com!news3.google.com!feeder3.cambriumusenet.nl!feed.tweaknews.nl!193.201.147.81.MISMATCH!feed.xsnews.nl!border-2.ams.xsnews.nl!newsfeed00.sul.t-online.de!newsfeed01.sul.t-online.de!t-online.de!newsfeed.straub-nv.de!feeder.eternal-september.org!eternal-september.org!.POSTED!not-for-mailReferences:
<m2d41p7sho.fsf@consult.pretender> <hht5o0$9pd$1@scotsman.ed.ac.uk> <m23a2l7myy.fsf@consult.pretender> <hhti24$9ua$1@scotsman.ed.ac.uk> <m2tyv15eaz.fsf@consult.pretender> <hhv7u9$bf4$1@scotsman.ed.ac.uk> <m2iqbg5zjg.fsf@consult.pretender> <hi0018$1gk$1@north.jnrs.ja.net> <m21vi45kxy.fsf@consult.pretender> <hi0e67$5b2$1@north.jnrs.ja.net> <m2tyv03yq9.fsf@consult.pretender> <m2pr5o3ycq.fsf@consult.pretender> <m2ljgc3xd3.fsf@consult.pretender> <hi2c72$l5i$1@north.jnrs.ja.net> <m2ocl7yvsr.fsf@consult.pretender> <hi4d25$81f$1@north.jnrs.ja.net>Show Full Headers
Complete Article Headers
X-Google-Thread: a16957f451,747cd7667796b3e3 X-Google-Attributes: gida16957f451,public,usenet X-Google-NewGroupId: yes X-Google-Language: ENGLISH,ASCII-7-bit Path: arc1-ca.pugleaf.net!g2news1.google.com!news3.google.com!feeder3.cambriumusenet.nl!feed.tweaknews.nl!193.201.147.81.MISMATCH!feed.xsnews.nl!border-2.ams.xsnews.nl!newsfeed00.sul.t-online.de!newsfeed01.sul.t-online.de!t-online.de!newsfeed.straub-nv.de!feeder.eternal-september.org!eternal-september.org!.POSTED!not-for-mail From: blueman <NOSPAM@nospam.com> Newsgroups: gnu.emacs.vm.bug Subject: Re: Suggested fix to vm-pipe-message-part Date: Thu, 07 Jan 2010 11:15:03 -0500 Organization: A noiseless patient Spider Lines: 44 Message-ID: <m24omxzybc.fsf@consult.pretender> References: <m2d41p7sho.fsf@consult.pretender> <hht5o0$9pd$1@scotsman.ed.ac.uk> <m23a2l7myy.fsf@consult.pretender> <hhti24$9ua$1@scotsman.ed.ac.uk> <m2tyv15eaz.fsf@consult.pretender> <hhv7u9$bf4$1@scotsman.ed.ac.uk> <m2iqbg5zjg.fsf@consult.pretender> <hi0018$1gk$1@north.jnrs.ja.net> <m21vi45kxy.fsf@consult.pretender> <hi0e67$5b2$1@north.jnrs.ja.net> <m2tyv03yq9.fsf@consult.pretender> <m2pr5o3ycq.fsf@consult.pretender> <m2ljgc3xd3.fsf@consult.pretender> <hi2c72$l5i$1@north.jnrs.ja.net> <m2ocl7yvsr.fsf@consult.pretender> <hi4d25$81f$1@north.jnrs.ja.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Date: Thu, 7 Jan 2010 16:15:03 +0000 (UTC) Injection-Info: news.motzarella.org; posting-host="o0xooYC/dlyFpPxuXQpbEw"; logging-data="26824"; mail-complaints-to="abuse@eternal-september.org"; posting-account="U2FsdGVkX19KR/w9DxmaEa0la50NVkHPWNfRPd6aoQI=" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) Cancel-Lock: sha1:R9LLQ0T9ylnqWndvn/ydY00zWKQ= sha1:GV/gVHaQzPIVsyJQlZLTLFhr86c=