Re: Suggested fix to vm-pipe-message-part

Article View: gnu.emacs.vm.bug

Article #240

#240

From: blueman
Date: Thu, 07 Jan 2010 19:02

47 lines
3193 bytes

Uday S Reddy <uDOTsDOTreddy@cs.bham.ac.uk> writes:
> blueman wrote:
>
>>> Whatever you posted here has been put in.  But in your version of the
>>> exit-handler below, notice that you added a 'command' argument but
>>> never used it!
>>
>> Sure it is used:
>>>>       (funcall exit-handler command buffer))))
>
> Right, you fell into the trap!  This is inside the scope of let, which
> rebinds 'command'.
>
> I just ran 'cat' with the |s operation, and it broke.
>
> process-command apparently returns a list of strings, which wasn't
> what was expected.
>
> Cheers,
> Uday

Well you clipped out the other part of my message:
     Plus, even if it weren't used, it still would create a problem since the
     function vm-pipe-command-exit-handler is called with 'command' placed in
     the second position.

So, either you add it here or you remove it from the two places in
vm-pipe-messages-to-command that call it.


		(vm-pipe-command-exit-handler 
		 process ,command ,discard-output 
		 (if (and ,no-wait (functionp ,no-wait))
		     ,no-wait)))

[remember you need to add the comma before the final no-wait above]


      (vm-pipe-command-exit-handler process command discard-output))


So maybe better to remove it from these two places -- then that would
make all my 'bug fixes' limited to vm-pipe-messages-to-command:
  1. Add comma before ,no-wait
  2. *Delete* command from the above two places

I will test it to be sure tonight...

Technical Details

Message-ID: <m2r5q1ybz4.fsf@consult.pretender>

Path:

arc1-ca.pugleaf.net!g2news1.google.com!news4.google.com!feeder.news-service.com!188.40.43.213.MISMATCH!feeder.eternal-september.org!eternal-september.org!.POSTED!not-for-mail

References:

<m2d41p7sho.fsf@consult.pretender> <hht5o0$9pd$1@scotsman.ed.ac.uk> <m23a2l7myy.fsf@consult.pretender> <hhti24$9ua$1@scotsman.ed.ac.uk> <m2tyv15eaz.fsf@consult.pretender> <hhv7u9$bf4$1@scotsman.ed.ac.uk> <m2iqbg5zjg.fsf@consult.pretender> <hi0018$1gk$1@north.jnrs.ja.net> <m21vi45kxy.fsf@consult.pretender> <hi0e67$5b2$1@north.jnrs.ja.net> <m2tyv03yq9.fsf@consult.pretender> <m2pr5o3ycq.fsf@consult.pretender> <m2ljgc3xd3.fsf@consult.pretender> <hi2c72$l5i$1@north.jnrs.ja.net> <m2ocl7yvsr.fsf@consult.pretender> <hi4d25$81f$1@north.jnrs.ja.net> <m24omxzybc.fsf@consult.pretender> <hi54kr$euu$1@north.jnrs.ja.net>

Show Full Headers

Complete Article Headers

X-Google-Thread: a16957f451,747cd7667796b3e3
X-Google-Attributes: gida16957f451,public,usenet
X-Google-NewGroupId: yes
X-Google-Language: ENGLISH,ASCII-7-bit
Path: arc1-ca.pugleaf.net!g2news1.google.com!news4.google.com!feeder.news-service.com!188.40.43.213.MISMATCH!feeder.eternal-september.org!eternal-september.org!.POSTED!not-for-mail
From: blueman <NOSPAM@nospam.com>
Newsgroups: gnu.emacs.vm.bug
Subject: Re: Suggested fix to vm-pipe-message-part
Date: Thu, 07 Jan 2010 14:02:55 -0500
Organization: A noiseless patient Spider
Lines: 47
Message-ID: <m2r5q1ybz4.fsf@consult.pretender>
References: <m2d41p7sho.fsf@consult.pretender>
 <hht5o0$9pd$1@scotsman.ed.ac.uk> <m23a2l7myy.fsf@consult.pretender>
 <hhti24$9ua$1@scotsman.ed.ac.uk> <m2tyv15eaz.fsf@consult.pretender>
 <hhv7u9$bf4$1@scotsman.ed.ac.uk> <m2iqbg5zjg.fsf@consult.pretender>
 <hi0018$1gk$1@north.jnrs.ja.net> <m21vi45kxy.fsf@consult.pretender>
 <hi0e67$5b2$1@north.jnrs.ja.net> <m2tyv03yq9.fsf@consult.pretender>
 <m2pr5o3ycq.fsf@consult.pretender> <m2ljgc3xd3.fsf@consult.pretender>
 <hi2c72$l5i$1@north.jnrs.ja.net> <m2ocl7yvsr.fsf@consult.pretender>
 <hi4d25$81f$1@north.jnrs.ja.net> <m24omxzybc.fsf@consult.pretender>
 <hi54kr$euu$1@north.jnrs.ja.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Injection-Date: Thu, 7 Jan 2010 19:02:55 +0000 (UTC)
Injection-Info: news.motzarella.org; posting-host="o0xooYC/dlyFpPxuXQpbEw";
 logging-data="1510"; mail-complaints-to="abuse@eternal-september.org"; posting-account="U2FsdGVkX18Jn4C1a32tJjikOmraKQFAbCy7Uq/x6SY="
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)
Cancel-Lock: sha1:UOo7w7Uf5+TlRsiIGhB29BJgMzE=
 sha1:9ulWu3HEaKZSifaAnqeC8c6kOcQ=

Reply to Parent Message