Article View: gnu.emacs.vm.bug
Article #301Re: Contributing changes [Re: Suggested fix to vm-pipe-message-part]
From: blueman
Date: Fri, 08 Jan 2010 15:08
Date: Fri, 08 Jan 2010 15:08
57 lines
5063 bytes
5063 bytes
Uday S Reddy <uDOTsDOTreddy@cs.bham.ac.uk> writes: > blueman wrote: > The launchpad bug reports are public, but email addresses are kept > private. People can also flag their issues as security issues if they > don't want them to be publicly visible. I don't mind moving to > bugzilla if we find launchpad bugs wanting. But, at the moment, we > are already distributed over two sites (launchpad and savannah) and I > wouldn't want to add a third site without good reason. That's reasonable - I think it is just that as an old-timer, I have been in the habit of discussing bugs here (as per the README). That is the way I interacted first with Kyle and then with Robert going back 20 years, though admittedly I have been quiet for the past two, mostly because my News provider didn't provide these groups for a while. > There is no reason why you shouldn't register on launchpad. Agreed. I was not familiar with launchpad and didn't realize until now that it provides a reasonable bug tracking interaction facility Still it is a bit confusing to me to have two places where bugs are discussed/submitted. It's not clear to me what the advantages are of having two places to discuss bugs or even when to use which place. > There is no problem with you reporting bugs, and also no problem with > you contributing fixes. The only problem arises if you are adamant > that the fixes should be implemented your way. Even more so if your > fixes fail my testing. I am not adamant that they are fixed my way -- just that they are fixed and that the code is clean (see my other posting). If you followed this thread, you can see that multiple times, I threw out my code and started again based on suggestions by Julian and you. I think part of the problem here is that you are trying a bit too hard to be the perfect maintainer by trying to do and fix everything yourself. I say this in a complimentary and constructive way. You don't need to fix everything yourself right away if you can't get my patches to work -- this code has been bad for years and a few more days of waiting won't kill anybody - particularly since I am probably the only person even using the optional variables that break the function. I will be happy to provide proper patches in the future, though I find that a PITA since I usually just patch functions rather than files (Perhaps we could come up with an emacs/vm command that would generate patches based on functions rather than files -- that would be very usefult to me). But please if I am taking the lead in fixing a bug, don't go off and fork your own fixes unless I fail to deliver in a reasonable enough amount of time (and for a fix like this 2 days is not a reasonable amount of time). I believe that this is what caused the confusion is that you started your own branch of fixing it indepedently when you failed to get my changes to work the first time. > I admit to having been irritated. But this was because I got the > impression that you weren't treating the issue with as much care as I > was putting into it. That is unfortunately a mistaken impression.
Technical Details
Message-ID:
<m2my0ows5o.fsf@consult.pretender>Path:
arc1-ca.pugleaf.net!g2news1.google.com!news3.google.com!feeder3.cambriumusenet.nl!feed.tweaknews.nl!193.201.147.78.MISMATCH!feeder.news-service.com!188.40.43.213.MISMATCH!feeder.eternal-september.org!eternal-september.org!.POSTED!not-for-mailReferences:
<m2d41p7sho.fsf@consult.pretender> <hhti24$9ua$1@scotsman.ed.ac.uk> <m2tyv15eaz.fsf@consult.pretender> <hhv7u9$bf4$1@scotsman.ed.ac.uk> <m2iqbg5zjg.fsf@consult.pretender> <hi0018$1gk$1@north.jnrs.ja.net> <m21vi45kxy.fsf@consult.pretender> <hi0e67$5b2$1@north.jnrs.ja.net> <m2tyv03yq9.fsf@consult.pretender> <m2pr5o3ycq.fsf@consult.pretender> <m2ljgc3xd3.fsf@consult.pretender> <hi2c72$l5i$1@north.jnrs.ja.net> <m2ocl7yvsr.fsf@consult.pretender> <hi4d25$81f$1@north.jnrs.ja.net> <m24omxzybc.fsf@consult.pretender> <hi54kr$euu$1@north.jnrs.ja.net> <m2r5q1ybz4.fsf@consult.pretender> <m2my0pybcx.fsf@consult.pretender> <hi5peg$kmp$1@north.jnrs.ja.net> <m2iqbdxbuj.fsf@consult.pretender> <hi770p$2j5$1@north.jnrs.ja.net>Show Full Headers
Complete Article Headers
X-Google-Thread: a16957f451,747cd7667796b3e3 X-Google-Attributes: gida16957f451,public,usenet X-Google-NewGroupId: yes X-Google-Language: ENGLISH,ASCII-7-bit Path: arc1-ca.pugleaf.net!g2news1.google.com!news3.google.com!feeder3.cambriumusenet.nl!feed.tweaknews.nl!193.201.147.78.MISMATCH!feeder.news-service.com!188.40.43.213.MISMATCH!feeder.eternal-september.org!eternal-september.org!.POSTED!not-for-mail From: blueman <NOSPAM@nospam.com> Newsgroups: gnu.emacs.vm.bug Subject: Re: Contributing changes [Re: Suggested fix to vm-pipe-message-part] Date: Fri, 08 Jan 2010 10:08:35 -0500 Organization: A noiseless patient Spider Lines: 57 Message-ID: <m2my0ows5o.fsf@consult.pretender> References: <m2d41p7sho.fsf@consult.pretender> <hhti24$9ua$1@scotsman.ed.ac.uk> <m2tyv15eaz.fsf@consult.pretender> <hhv7u9$bf4$1@scotsman.ed.ac.uk> <m2iqbg5zjg.fsf@consult.pretender> <hi0018$1gk$1@north.jnrs.ja.net> <m21vi45kxy.fsf@consult.pretender> <hi0e67$5b2$1@north.jnrs.ja.net> <m2tyv03yq9.fsf@consult.pretender> <m2pr5o3ycq.fsf@consult.pretender> <m2ljgc3xd3.fsf@consult.pretender> <hi2c72$l5i$1@north.jnrs.ja.net> <m2ocl7yvsr.fsf@consult.pretender> <hi4d25$81f$1@north.jnrs.ja.net> <m24omxzybc.fsf@consult.pretender> <hi54kr$euu$1@north.jnrs.ja.net> <m2r5q1ybz4.fsf@consult.pretender> <m2my0pybcx.fsf@consult.pretender> <hi5peg$kmp$1@north.jnrs.ja.net> <m2iqbdxbuj.fsf@consult.pretender> <hi770p$2j5$1@north.jnrs.ja.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Date: Fri, 8 Jan 2010 15:08:35 +0000 (UTC) Injection-Info: news.motzarella.org; posting-host="o0xooYC/dlyFpPxuXQpbEw"; logging-data="3066"; mail-complaints-to="abuse@eternal-september.org"; posting-account="U2FsdGVkX18juZSY8rgHmfseUj3nhVSX2NvvS1TPcqc=" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) Cancel-Lock: sha1:CHYOKHELSeO1yq1pJ2ZPskF+eRA= sha1:Odl6iKHXbhjq9yU7bdoFfQSWUIs=