🚀 go-pugleaf

newsspam5REMOVETHIS@robf.de writes:
> blueman <NOSPAM@nospam.com> writes:
> > Just installed the Fedora rpm (8.0.2.482-4) for Fedora Core 6.
> >
> > Every time I try to vm-mail or vm-reply-to to an email I get the following
> > error:
> >
> > Debugger entered--Lisp error: (void-function locate-file)
> >   locate-file("bzr.exe" ("/usr/kerberos/bin" "/home/kosowsky/bin"
> >   "/usr/local/b$
> >   vm-version()
> >   vm-mail-internal(nil nil nil)
> >   vm-mail()
> > * call-interactively(vm-mail)
> >
> >
> > I am using emacs 21.4.1.
> > Is it possible that this is an xemacs function that is not found in
> > gnu emacs?
> 
> It is there in Emacs 22 and XEmacs, but not in Emacs 21
> 
> This error should not happen unless you are running a development
> version, i.e. if VM finds a .bzr directory in the directory ../
> relative to the vm.el source file, but then it also should not
> search for bzr ...
> 

Well, I am running emacs 21.4.1 which is the default version that
comes with Fedora Core 6 and I don't have any bzr directories.

I then went back and compared the binaries in 8.0.1 and 8.0.2 and I
believe I found the problem.

The function vm-version in 8.0.2, contains the following lines...
   (let* ((f (locate-library "vm"))
             (d (file-name-directory f))
             (b (get-buffer " *vm-version*"))
         (devo (file-exists-p (expand-file-name ".bzr" (concat d
             "../"))))
         (bzr (or (locate-file "bzr.exe" exec-path)
         ...

So, you see that the function "locate-file" is called ALL THE TIME,
independent of whether or not a 'bzr' directory exists.

In contrast, in 8.0.1, 'locate-file' is only called if the bzr
directory exists due to the following 'cond' statement:
        (cond ((and (file-exists-p (expand-file-name ".bzr" (concat d "../")))
            (locate-file "bzr" exec-path)


So, I believe that the code in 8.0.2 (and presumably also in your
newer versions) needs to be fixed so that locate-file is only called
if the .bzr directory exists.

I am surprised though that others have not run into this bug since it
should effect any user of emacs versions before 22 anytime they try to
actually compose an email.