🚀 go-pugleaf

RetroBBS NetNews Server

Inspired by RockSolid Light RIP Retro Guy

Article View: gnu.emacs.vm.bug
Article #479

Re: buglet (?) in qp-decode.c

#479
From: blueman
Date: Tue, 01 Jul 2008 00:02
39 lines
2738 bytes
Ralf Fassel <ralfixx@gmx.de> writes:
> When a quoted-printable message is incorrectly terminated at EOF:
>
>     p;</td>=0A=0A        <td width=3D"49%">&nbsp;</td>=0A      </tr>=0A    </tb=
>     ody>=0A  </table>=0A</body>=0A</html>=0A=
>     --=_mixed 002D08B5C1257475_=--
>
> (missing newline before the separator) qp-decode barfs:
>
> Error: line 758: '^@' is something other than line break or hex digit after = in quoted-printable encoding
>
> and continues to read into the invalid buffer contents.
>
> IMHO, if EOF is encountered, it simply should stop processing and
> issue no error message:
>
> *** src/qp-decode.c~	Wed Feb 20 22:11:51 2008
> --- src/qp-decode.c	Mon Jun 30 12:03:41 2008
> ***************
> *** 88,93 ****
> --- 88,94 ----
>   		for (stop++; *stop && (*stop == ' ' || *stop == '\t'); stop++)
>   		    ;
>   	    } else {
> + 	      if (feof(stdin)) exit(0);
>   		fprintf(stderr, "Error: line %d: '%c' is something other than line break or hex digit after = in quoted-printable encoding\n", lineno, *stop);
>   		putchar('=');
>   		putchar(*stop);
>
>
> R'

I think I had noticed and reported a similar issue about 18 months
ago. Robert also submitted a patch which I thought was now part of the
standard VM distribution (but maybe not).

You may want to go back in the archives:
http://groups.google.com/group/gnu.emacs.vm.info/browse_thread/thread/5b30c79c9137e55a/9b1f53c459d6c915?lnk=st&q=blueman++qp-decode#
http://groups.google.com/group/gnu.emacs.vm.bug/browse_thread/thread/7b3640b3291cc9bc
Technical Details
Message-ID: <m2skuulbe4.fsf@consult.pretender>
Path: arc1-ca.pugleaf.net!g2news1.google.com!news4.google.com!feeder.news-service.com!feeder.news-service.com!news.motzarella.org!motzarella.org!not-for-mail
References: <ygalk0ni65f.fsf@gepard2.akutech-local.de>

Show Full Headers
Complete Article Headers
X-Google-Thread: f6829,141bbfda3d9204c6
X-Google-Attributes: gidf6829,domainid0,public,usenet
X-Google-Language: ENGLISH,ASCII-7-bit
Path: arc1-ca.pugleaf.net!g2news1.google.com!news4.google.com!feeder.news-service.com!feeder.news-service.com!news.motzarella.org!motzarella.org!not-for-mail
From: blueman <NOSPAM@nospam.com>
Newsgroups: gnu.emacs.vm.bug
Subject: Re: buglet (?) in qp-decode.c
Date: Mon, 30 Jun 2008 20:02:27 -0400
Organization: A noiseless patient Spider
Lines: 39
Message-ID: <m2skuulbe4.fsf@consult.pretender>
References: <ygalk0ni65f.fsf@gepard2.akutech-local.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Trace: feeder.motzarella.org U2FsdGVkX19tygFofwec57NfULKkZApd0fv+BGJ68z3xXaQ0463Es4Fs6j7Vluz2ldhl6N8Wkr6DDqwuHrUyC4img4a1m9YnpbD3whrPkdfj+wIsYavJS7V45rXo7uC9c10dHi4/wCU=
X-Complaints-To: Please send complaints to abuse@motzarella.org with full headers
NNTP-Posting-Date: Tue, 1 Jul 2008 00:02:35 +0000 (UTC)
X-Auth-Sender: U2FsdGVkX18GmIXVl4IqxuIEj6g3LG4cttwglyD41Et8+L1Gk7YuUw==
Cancel-Lock: sha1:PKrMyugXKhqZEHnEOzprqzaz4Pw=
 sha1:SWylVVEkJTjRsEJAJOU1+famjqI=
User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux)