Re: buglet (?) in qp-decode.c

Article View: gnu.emacs.vm.bug

Article #481

#481

From: newsspam5REMOVETHIS
Date: Sat, 05 Jul 2008 21:25

24 lines
1778 bytes

Ralf Fassel <ralfixx@gmx.de> writes:
[...]
> Maybe at (1) another check for
>    else if (*stop == '\0')
> needs to be added instead or in addition of the feof() check.

Does the following work for you?

Robert

=== modified file 'src/qp-decode.c'
--- src/qp-decode.c	2007-01-12 01:50:26 +0000
+++ src/qp-decode.c	2008-07-05 21:23:47 +0000
@@ -63,7 +63,9 @@
 	    continue;
 	} else { /* *stop == '=' */
 	    stop++;
-	    if ((d1 = strchr(hexdigits, *(stop))) &&
+	    if (*stop == 0) {
+		continue;
+	    } else if ((d1 = strchr(hexdigits, *(stop))) &&
 		(d2 = strchr(hexdigits, *(stop+1)))) {
 		c = (d1 - hexdigits) * 16 + (d2 - hexdigits);
 		putchar(c);

Technical Details

Message-ID: <85prps58hn.fsf@robf.de>

Path:

arc1-ca.pugleaf.net!g2news1.google.com!news1.google.com!news.glorb.com!feeder.erje.net!news-fra1.dfn.de!news-nue1.dfn.de!newsfeed.r-kom.de!news.m-online.net!not-for-mail

References: <ygalk0ni65f.fsf@gepard2.akutech-local.de> <m2skuulbe4.fsf@consult.pretender> <yga4p7ahvjc.fsf@gepard2.akutech-local.de>

Show Full Headers

Complete Article Headers

X-Google-Thread: f6829,141bbfda3d9204c6
X-Google-Attributes: gidf6829,domainid0,public,usenet
X-Google-Language: ENGLISH,ASCII-7-bit
Path: arc1-ca.pugleaf.net!g2news1.google.com!news1.google.com!news.glorb.com!feeder.erje.net!news-fra1.dfn.de!news-nue1.dfn.de!newsfeed.r-kom.de!news.m-online.net!not-for-mail
From: newsspam5REMOVETHIS@robf.de
Newsgroups: gnu.emacs.vm.bug
Subject: Re: buglet (?) in qp-decode.c
Date: Sat, 05 Jul 2008 23:25:24 +0200
Organization: (posted via) M-net Telekommunikations GmbH
Lines: 25
Message-ID: <85prps58hn.fsf@robf.de>
References: <ygalk0ni65f.fsf@gepard2.akutech-local.de> <m2skuulbe4.fsf@consult.pretender> <yga4p7ahvjc.fsf@gepard2.akutech-local.de>
NNTP-Posting-Host: ppp-88-217-0-127.dynamic.mnet-online.de
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Trace: svr7.m-online.net 1215293125 14251 88.217.0.127 (5 Jul 2008 21:25:25 GMT)
X-Complaints-To: abuse@m-online.net
NNTP-Posting-Date: Sat, 5 Jul 2008 21:25:25 +0000 (UTC)
User-Agent: Gnus/5.1008 (Gnus v5.10.8) XEmacs/21.4.21 (linux)
Cancel-Lock: sha1:3bvIF4rfX0dnF0a+sGyYsQOOLhg=

Reply to Parent Message