🚀 go-pugleaf

i'm working on getting VM set up with smtpmail (or esmtpmail) to send
outgoing messages via SMTP.

inside of the function: smtpmail-send-it, there's code to fill in the
>From header (about line 282).


;; Put the "From:" field in unless for some odd reason
;; they put one in themselves.
(goto-char (point-min))
(if (not (re-search-forward "^From:" delimline t))
(let* ((login smtpmail-mail-address)
       (fullname (user-full-name)))
  (cond ((eq mail-from-style 'angles)

-----------------

inside of the cond are three clauses to put in an appropriate From
header based on the mail-from-style.

on my version of emacs (GNU Emacs 21.4.1 (i386-pc-linux-gnu, X toolkit,
Xaw3d scroll bars) of 2005-03-17 on trouble, modified by Debian), i
think that the let* is causing the cond code to not execute, or perhaps
the insert function is not executing, because no from header is being
written to the message buffer.

i mucked around for quite a while, adding calls to 'message' and
whatnot, and i could not get a From line to get added in to the message
buffer, nor any output to the *Messages* buffer from within that cond
block, or otherwise within the let* block.

finally, i changed the let* to a let, changed all references to the
vars login and fullname to point to smtp-mail-address and
user-full-name, and poof!  back in business.

technically, i only changed this in the esmtpmail code, so i don't know
if the same exact issue exists with smtpmail.el.  but that block of
code is identical between the two files, so it seems like it would
still be a problem.

i'm not sure why there was a perceived need for a let*. the variables
that are being created are only referenced once or twice. and nothing
terribly sophisticated is being done to them.

anyways, there it is.  i'd love to know if someone thinks that i'm
misinterpreting.  i can post my patched code somewhere if it's helpful.

i notice that the same code (with the let*) exists in sendmail.el, and
that this works just fine on another system where i'm using
sendmail-send-it with emacs 20.4.1.