🚀 go-pugleaf

RetroBBS NetNews Server

Inspired by RockSolid Light RIP Retro Guy

Article View: gnu.emacs.vm.bug
Article #682

vm-7.18: errors while vm-retrieved-spooled-mail-hook funcs run not handled gracefully

#682
From: Greg A. Woods
Date: Fri, 05 Dec 2003 03:23
37 lines
2578 bytes
In vm-7.18 any errors which occur while vm-retrieved-spooled-mail-hook
functions run are not handled very gracefully.

It seems as though the INBOX buffer is unchanged even though the
retrieved messages have indeed been appended to it.  This is no doubt
because vm-assimilate-new-messages never gets called.

I made the following note about this issue in my sources:

Index: vm-folder.el
===================================================================
RCS file: /cvs/elisp/vm6/vm-folder.el,v
retrieving revision 1.1.1.20
diff -c -c -r1.1.1.20 vm-folder.el
*** vm-folder.el	23 Nov 2003 20:07:05 -0000	1.1.1.20
--- vm-folder.el	5 Dec 2003 03:21:38 -0000
***************
*** 3739,3744 ****
--- 3740,3751 ----
  	(setq vm-spooled-mail-waiting nil)
  	(intern (buffer-name) vm-buffers-needing-display-update)
  	(vm-update-summary-and-mode-line)
+ 	;; XXX if an error is signaled during run-hooks then the user won't see
+ 	;; the new message even though they are there!  The problem seems to be
+ 	;; similar to the one above with retrival-function.  The solution
+ 	;; though may simply be to ignore the error and go on to assimilate,
+ 	;; hoping that the errant hook function didn't do anything destructive
+ 	;; that can't be undone....  There's always vm-keep-crash-boxes too.
  	(if got-mail
  	    (run-hooks 'vm-retrieved-spooled-mail-hook))
  	(and got-mail (vm-assimilate-new-messages t))))))

-- 
						Greg A. Woods

+1 416 218-0098                  VE3TCP            RoboHack <woods@robohack.ca>
Planix, Inc. <woods@planix.com>          Secrets of the Weird <woods@weird.com>
Technical Details
Message-ID: <874qwggd6c.fsf@proven.weird.com>
Path: arc1-ca.pugleaf.net!archiver1.google.com!news2.google.com!newsfeed2.dallas1.level3.net!news.level3.com!crtntx1-snh1.gtei.net!news.gtei.net!newsfeed1.easynews.com!easynews.com!easynews!elnk-pas-nf1!newsfeed.earthlink.net!pd7cy1no!shaw.ca!sn-xit-03!sn-xit-04!sn-xit-06!sn-post-01!supernews.com!corp.supernews.com!not-for-mail

Show Full Headers
Complete Article Headers
X-Google-Language: ENGLISH,ASCII-7-bit
X-Google-Thread: f6829,60db197cb4105420,start
X-Google-Attributes: gidf6829,public
X-Google-ArrivalTime: 2003-12-04 19:23:59 PST
Path: arc1-ca.pugleaf.net!archiver1.google.com!news2.google.com!newsfeed2.dallas1.level3.net!news.level3.com!crtntx1-snh1.gtei.net!news.gtei.net!newsfeed1.easynews.com!easynews.com!easynews!elnk-pas-nf1!newsfeed.earthlink.net!pd7cy1no!shaw.ca!sn-xit-03!sn-xit-04!sn-xit-06!sn-post-01!supernews.com!corp.supernews.com!not-for-mail
From: woods@proven.weird.com (Greg A. Woods)
Newsgroups: gnu.emacs.vm.bug
Subject: vm-7.18: errors while vm-retrieved-spooled-mail-hook funcs run not handled gracefully
Date: 04 Dec 2003 22:23:55 -0500
Organization: Planix, Inc.; Toronto, Ontario; Canada
Message-ID: <874qwggd6c.fsf@proven.weird.com>
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Complaints-To: abuse@supernews.com
Lines: 37