🚀 go-pugleaf

Kevin Rodgers <ihs_4664@yahoo.com> writes:
> Jeffrey J. Kosowsky wrote:
> 
> > I am really enjoying the ability added in VM-7.18 that launches
> > attachments under their actual file name as opposed to just using a
> > random temp file name.
> > However, I have noticed that files with spaces in them fail to launch
> > properly, though the file itself is detached to the temp directory under the
> > proper full file name.
> > I imagine that this is probably due to file names not being properly
> > quoted to preserve spaces and other such non-alphanumeric characters.
> > Any thoughts where source of error is and how to fix?
> 
> Such file names should only cause a problem if the external program is launched
> via the shell.  Does this patch to vm-mime-display-external-generic help?
> 
> *** vm-7.18/vm-mime.el.orig	Mon Oct 13 13:30:18 2003
> --- vm-7.18/vm-mime.el	Mon Jan 12 15:29:13 2004
> ***************
> *** 2003,2008 ****
> --- 2003,2012 ----
>    	       (write-region start end tempfile nil 0)
>    	       (delete-region start end))))
> 
> +       ;; quote file name for shell command only
> +       (or (cdr program-list)
> +           (setq tempfile (shell-quote-argument tempfile)))
> +
>          ;; expand % specs
>          (let ((p program-list)
>    	    (vm-mf-attachment-file tempfile))

Thanks... this seems to correct the problem with files with spaces.
Can we get Kyle to include the above patch in the next release of vm?

However, I have now noticed another problem. If there already is
another version of the file in the temp directory with the same name,
then vm just hangs in opening the file. 

A better alternative might be to first check if the stored file is
identical. If so, then just open the existing temp file, if not then
store the file with a modified file name, such as <filename>.1

In any case the current "hanging" response should be fixed, right?

Thanks,
Jeff