🚀 go-pugleaf

kosowsky@consult.pretender (Jeffrey J. Kosowsky) writes:

> newsspam5REMOVETHIS@robf.de writes:
>> kosowsky@consult.pretender (Jeffrey J. Kosowsky) writes:
>> > Kevin Rodgers <ihs_4664@yahoo.com> writes:
>> >> Jeffrey J. Kosowsky wrote:
>> >> 
>> >> > However, I have now noticed another problem. If there already is
>> >> > another version of the file in the temp directory with the same name,
>> >> > then vm just hangs in opening the file. A better alternative might
>> >> > be to first check if the stored file is
>> >> > identical. If so, then just open the existing temp file, if not then
>> >> > store the file with a modified file name, such as <filename>.1
>> >> > In any case the current "hanging" response should be fixed, right?
>> >> 
>> >> Are you sure that it is actually hung (meaning you have to use C-g to
>> >> get Emacs to respond to further commands) and not just doing
>> >> nothing?
>> >
>> > Truly hung -- blank, frozen, unresponsive screen until I press C-g.
>> > This is repeatable.
>> 
>> M-: (setq debug-on-quit t) RET
>> 
>> and have a look at the backtrace, this should identify the defun
>> causing the hang.
>
> This is what I got (but not sure what it means...):
>
> Debugger entered--Lisp error: (quit)
>   expand-file-name("1092672-My Document.DOC" "/tmp")
>   apply(expand-file-name ("1092672-My Document.DOC" "/tmp"))
>   ange-ftp-completion-hook-function(expand-file-name "1092672-My Document.DOC" "/tmp")
>   expand-file-name("1092672-My Document.DOC" "/tmp")
>   vm-make-tempfile-name(".DOC" "My Document.DOC")

Hmm from the code in `vm-make-tempfile-name' I would guess, that
it hangs in the while-loop trying to find an unused name ...
[looking at it] ... IMHO it is a bug indeed, there was a
miss-placed parenthesis in the second case of the cond, at least
in VM 7.18.

Apply the patch below and DONE is set to terminate the loop
correctly [untested].

--- .hacking/vm-7.18/vm-misc.el	2003-11-03 16:37:56.000000000 +0100
+++ .xemacs/xemacs-packages/vm/lisp/vm-misc.el	2004-01-22 16:54:01.000000000 +0100
@@ -635,8 +646,8 @@
 					vm-tempfile-counter
 					proposed-filename)
 				vm-temp-file-directory))
-		     vm-tempfile-counter (1+ vm-tempfile-counter))
-	       done (not (file-exists-p filename)))))
+		     vm-tempfile-counter (1+ vm-tempfile-counter)
+                     done (not (file-exists-p filename))))))
 	  (t
 	   (let ((done nil))
 	     (while (not done)