🚀 go-pugleaf

Jeffrey J. Kosowsky wrote:
 > Kevin Rodgers <ihs_4664@yahoo.com> writes:
 >>Indeed.  What is system-type on your platform?
 >
 > windows-nt (which I believe is what you get on NT, Win2K, WinXP, etc)
 > Now according to the code for shell-quote-argument, in that case all
 > that happens is that \" is added to the beginning and end of the
 > string. This seems to be "wrong" according to the help screen on 'cmd'
 > under winxp.
 >
 > Is this a "bug" in subr.el that should be reported to the general
 > emacs group or am I missing something here?

Yes, I think you should report it as a bug.

 >>lisp/subr.el defines shell-quote-argument, and its result depends on
 >>that variable.  But none of the alternatives use the quoting
 >>convention you describe.
 >>
 >>If cmd is the shell you use for M-! and M-|, you can probably just redefine
 >>it:
 >>
 >>      (defun cmd-quote-argument (argument)
 >>   "Quote ARGUMENT for a `cmd` command."
 >>   (let ((result "")
 >>	(start 0)
 >>	end)
 >>     (while (string-match "[][ &(){}^=;!'+,`~]" argument start)
 >>       (setq end (match-beginning 0)
 >>	    result (concat result
 >> 
		   (substring argument start end)
 >> 
		   "\"" (substring argument end (1+ end)) "\"")
 >>	    start (1+ end)))
 >>     (concat result (substring argument start))))
 >>
 >>(defalias 'shell-quote-argument 'cmd-quote-argument)
 >
 > I did something just like the above (but also needed to add the
 > <space> as  you pointed out (and it works!!!)

Uh, there is a space in the regexp: left square bracket, right square bracket,
left square bracket, space, ampersand, ...

 > I ended up adding the following:
 >
 > (defun shell-quote-argument-winxp (argument)
 >   "Quote an argument for passing as argument to an inferior shell.
 > Special fixed version for WinXP (JJK)"
 >   (let
 >           ((result "") (start 0) end)
 >         (while (string-match "[][&(){}^=;!'+,`~ ]" argument start)
 >             (setq end (match-beginning 0)
 >                   result (concat result (substring argument start end)
 >                                  "\"" (substring argument end (1+ end)) "\"")
 >                   start (1+ end)))
 >         (concat result (substring argument start))))
 >
 > (if (eq system-type 'windows-nt)
 >         (defalias 'shell-quote-argument 'shell-quote-argument-winxp))
 >

Glad it's working for you.

-- 
Kevin Rodgers