🚀 go-pugleaf

Regarding my patch to add ISO-8601 dates to some aspects of VM:

>>>>> "Kyle" == Kyle Jones <kyle_jones@wonderworks.com> writes:

Kyle> Thanks for the patch.

You're welcome.  Thank *you* for the great mail reader.  :)

Two of the regexes that got split out are just deconstructed and
lightly-commented versions of some from "vm-su-do-date", with two
changes:

1. I added anchors ("^" and "$").  This might have been excess
   paranoia; I don't know precisely how this will be called, but I
   figured that DATE would usually be just the date string proper, and
   not a whole header line, or have extra whitespace around it, etc.

2. To match either the + or - prefix to a time zone, the original
   regexps had:

      "\\(-\\|\\+\\)"

   Since this group was never referenced, and all those backwhacks
   were starting to give me headaches, I replaced it with:

      "[+---]"

   (Which is actually used elsewhere in that file, so I figure it's
   ok.)

   Traditionally, a minus inside a character range is treated as
   non-special if it doesn't actually form a range; thus, we might be
   able to use just "[+-]" and save a bit more visual strain.
   Seems to work with isearch-forward-regexp, at least...

If you like, here's a patch that updates vm-su-do-date to use the
regex constants.  The comments on the date formats are moved up to
where the constants are created.  Please do sanity check the change to
anchored regexps, though!

Patch is incremental; if a full patch off the released 7.11 would work
better, just let me know, and I can generate it easily.

diff -ur vm-7.11p1/vm-summary.el vm-7.11p2/vm-summary.el
--- vm-7.11p1/vm-summary.el	2003-03-12 19:59:08.000000000 -0700
+++ vm-7.11p2/vm-summary.el	2003-03-12 19:58:34.000000000 -0700
@@ -810,6 +810,9 @@
       "")))
 
 (defconst vm-parse-date-rfc822-re
+  ;; The date format recognized here is the one specified in RFC 822.
+  ;; Some slop is allowed e.g. dashes between the monthday, month and
+  ;; year because such malformed headers have been observed.
   (let ((abbrev "[a-z][a-z][a-z]")      ; month and day abbrevs
         (ws     "[ \t\n]*")             ; white space
         (wsd    "[ \t\n---]*"))         ; white space or dashes
@@ -887,6 +890,8 @@
   "Regular expression used to parse `ctime(3)' formatted dates")
 
 (defun vm-parse-date-ctime (date)
+  ;; UNIX ctime(3) format, with slop allowed in the whitespace, and we
+  ;; allow for the possibility of a timezone at the end.
   (if (string-match vm-parse-date-ctime-re date)
       (let ((weekday  (vm-parse-date-get-substring date 1))
             (month    (vm-parse-date-get-substring date 2))
@@ -947,12 +952,7 @@
       (vm-set-year-of m "")
       (vm-set-hour-of m "")
       (vm-set-zone-of m ""))
-     ((string-match
-;; The date format recognized here is the one specified in RFC 822.
-;; Some slop is allowed e.g. dashes between the monthday, month and year
-;; because such malformed headers have been observed.
-"\\(\\([a-z][a-z][a-z]\\),\\)?[ \t\n]*\\([0-9][0-9]?\\)[ \t\n---]*\\([a-z][a-z][a-z]\\)[ \t\n---]*\\([0-9]*[0-9][0-9]\\)[ \t\n]*\\([0-9:]+\\)[ \t\n]*\\([a-z][a-z]?[a-z]?\\|\\(-\\|\\+\\)[01][0-9][0-9][0-9]\\)"
-       date)
+     ((string-match vm-parse-date-rfc822-re date)
       (if (match-beginning 2)
 	  (vm-su-do-weekday m (substring date (match-beginning 2)
 					    (match-end 2)))
@@ -968,11 +968,7 @@
 		   (vm-set-year-of m (concat "19" (vm-year-of m)))))))
       (vm-set-hour-of m (substring date (match-beginning 6) (match-end 6)))
       (vm-set-zone-of m (substring date (match-beginning 7) (match-end 7))))
-     ((string-match
-;; UNIX ctime(3) format, with slop allowed in the whitespace, and we allow for
-;; the possibility of a timezone at the end.
-"\\([a-z][a-z][a-z]\\)[ \t\n]*\\([a-z][a-z][a-z]\\)[ \t\n]*\\([0-9][0-9]?\\)[ \t\n]*\\([0-9:]+\\)[ \t\n]*\\([0-9][0-9][0-9][0-9]\\)[ \t\n]*\\([a-z][a-z]?[a-z]?\\|\\(-\\|\\+\\)[01][0-9][0-9][0-9]\\)?"
-       date)
+     ((string-match vm-parse-date-ctime-re date)
       (vm-su-do-weekday m (substring date (match-beginning 1)
 				     (match-end 1)))
       (vm-su-do-month m (substring date (match-beginning 2) (match-end 2)))
Only in vm-7.11p1: vm-summary.el~