Re: vm-overlay-keymap (vm-edit.el) broken in emacs 19.16, vm5.33?

Article View: gnu.emacs.vm.bug

Article #8642

#8642

From: Bernd Petersohn
Date: Fri, 16 Jul 1993 07:18

32 lines
2198 bytes

`vm-overlay-keymap' fails because of incompatible changes of the keymap
data structures.  On the other hand, `vm-overlay-keymap' has become
rather obsolete because keymaps can now be inherited in Emacs 19.

Since `vm-edit-message' is the only command that has used the
`vm-overlay-keymap' function, I changed it such that it makes use of
the new inheritance feature and that it installs the keymap itself.

*** vm-edit.el~	Fri Jul 16 07:47:25 1993
--- vm-edit.el	Fri Jul 16 07:49:28 1993
***************
*** 67,75 ****
  	    (funcall (or vm-edit-message-mode 'text-mode))
  	    (setq vm-message-pointer mp
  		  vm-mail-buffer folder-buffer)
! 	    (use-local-map (copy-keymap (or (current-local-map)
! 					    (make-sparse-keymap))))
! 	    (vm-overlay-keymap vm-edit-message-mode-map (current-local-map))
  	    (message "Type C-c ESC to end edit, C-c C-] to abort with no change."))
  	(switch-to-buffer edit-buf)))))
  
--- 67,74 ----
  	    (funcall (or vm-edit-message-mode 'text-mode))
  	    (setq vm-message-pointer mp
  		  vm-mail-buffer folder-buffer)
! 	    (use-local-map (append vm-edit-message-mode-map
! 				   (cons 'keymap (current-local-map))))
  	    (message "Type C-c ESC to end edit, C-c C-] to abort with no change."))
  	(switch-to-buffer edit-buf)))))
  
-- 
Bernd Petersohn <muecke@cs.tu-berlin.de>

Technical Details

Message-ID: <225h8k$hb2@news.cs.tu-berlin.de>

Path: arc1-ca.pugleaf.net!gmd.de!Germany.EU.net!mcsun!uunet!math.fu-berlin.de!cs.tu-berlin.de!muecke

References: <MARCG.93Jul15094715@array.arraycomm.com>

Show Full Headers

Complete Article Headers

X-Google-Language: ENGLISH,ASCII-7-bit
X-Google-Thread: f6829,df829e68fdad174d
X-Google-Attributes: gidf6829,public
X-Google-ArrivalTime: 1993-07-15 23:23:37 PST
Path: arc1-ca.pugleaf.net!gmd.de!Germany.EU.net!mcsun!uunet!math.fu-berlin.de!cs.tu-berlin.de!muecke
From: muecke@cs.tu-berlin.de (Bernd Petersohn)
Newsgroups: gnu.emacs.vm.bug
Subject: Re: vm-overlay-keymap (vm-edit.el) broken in emacs 19.16, vm5.33?
Date: 16 Jul 93 07:18:57 GMT
Organization: Technical University of Berlin, Germany
Lines: 32
Distribution: gnu
Message-ID: <225h8k$hb2@news.cs.tu-berlin.de>
References: <MARCG.93Jul15094715@array.arraycomm.com>
NNTP-Posting-Host: lira.cs.tu-berlin.de
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
In-reply-to: marcg@array.arraycomm.com's message of 15 Jul 93 17:47:15 MET

Reply to Parent Message