🚀 go-pugleaf

RetroBBS NetNews Server

Inspired by RockSolid Light RIP Retro Guy

Article View: gnu.emacs.vm.bug
Article #8790

Bug when vm-included-text-prefix = "", and question about patch proceduures

#8790
From: David Mercer
Date: Thu, 25 Mar 1993 11:04
40 lines
2432 bytes
First, I want to report a bug in 5.32B:

When vm-included-text-prefix is "", VM hangs indefinitely (until you
press ^G) when you reply with included text for current message.  It's
a fairly easy fix, and it's fairly obvious why it is happening if you
take a look at vm-mail-yank-default() in vm-reply.el.  Here's the
patch I made:  (Place this in your ~/.vm.)

(defun vm-mail-yank-default (message)
  (save-excursion
    (delete-region (point) (progn (search-forward "\n\n") (point)))
    (if vm-included-text-attribution-format
	(insert (vm-sprintf 'vm-included-text-attribution-format message)))
    (while (and (re-search-forward "^" nil t) (< (point) (mark)))
      (replace-match vm-included-text-prefix t t)
      (forward-line 1))))

[The change is the addition of "(forward-line 1)" at the end.  In 5.32
production, this should be incorporated as part of vm-reply.el.]


That brings me to my second question:

What should I do to patch this and other problems I find?  I don't
want to repeat someone else's work, so is there a way for me to find
all the reported bugs that are currently being worked on, or that have
already been fixed?

When I come up with a fix, how do I get it incorporated in the
production version of VM?  (Don't want my work to go to waste,
either.)

And also, is this an appropriate forum for me to bring up my wish-list
for discussion?  Before I make a bug-fix/enhancement, I would like to
know what others think.

Thanks.

---DBM
Technical Details
Message-ID: <DMERCER.93Mar25030411@ap1pyr.oracle.com>
Path: arc1-ca.pugleaf.net!sparky!uunet!oracle!unrepliable!bounce

Show Full Headers
Complete Article Headers
X-Google-Language: ENGLISH,ASCII-7-bit
X-Google-Thread: 113a48,ec03c05d5865ebe1,start
X-Google-Attributes: gid113a48,public
X-Google-Thread: f6829,ec03c05d5865ebe1,start
X-Google-Attributes: gidf6829,public
X-Google-ArrivalTime: 1993-03-26 01:05:14 PST
Path: arc1-ca.pugleaf.net!sparky!uunet!oracle!unrepliable!bounce
Newsgroups: gnu.emacs.vm.bug,gnu.emacs.vm.info
From: dmercer@oracle.com (David Mercer)
Subject: Bug when vm-included-text-prefix = "", and question about patch proceduures
Message-ID: <DMERCER.93Mar25030411@ap1pyr.oracle.com>
Sender: usenet@oracle.us.oracle.com (Oracle News Poster)
Nntp-Posting-Host: ap1pyr.us.oracle.com
Organization: Oracle Corp., Belmont CA
Date: Thu, 25 Mar 1993 11:04:11 GMT
X-Disclaimer: This message was written by an unauthenticated user
              at Oracle Corporation.  The opinions expressed are those
              of the user and not necessarily those of Oracle.
Lines: 40