🚀 go-pugleaf

Some time ago, I posted a complaint about how VM changes the value
case-fold-search within its buffers.  If I remember right, Kyle agreed
this was wrong, but as far as I can tell, 5.32 beta is no different
from 5.31 beta in this respect.  This workaround

(setq vm-mode-hooks (list (function (lambda () (setq case-fold-search nil)))))

causes other problems.  All of the ones I've found are fixed by the
enclosed patch.  This patch is against 5.31, not 5.32, but it works
for both (with line number offsets in 5.32).

The motivation for all this is the idea that case-fold-search, as a
user preference, should not require a specific value in order for VM
to work as intended.  This patch adds scoping where necessary.


*** vm-reply..el	Sun Mar 31 17:42:13 1991
--- vm-reply.el	Sat Jan 11 01:09:17 1992
***************
*** 127,133 ****
  
  (defun vm-strip-ignored-addresses (addresses)
    (setq addresses (copy-sequence addresses))
!   (let (re-list list)
      (setq re-list vm-reply-ignored-addresses)
      (while re-list
        (setq addr-list addresses)
--- 127,134 ----
  
  (defun vm-strip-ignored-addresses (addresses)
    (setq addresses (copy-sequence addresses))
!   (let ((case-fold-search t)
! 	re-list list)
      (setq re-list vm-reply-ignored-addresses)
      (while re-list
        (setq addr-list addresses)
*** vm-group..el	Thu Mar 28 09:50:49 1991
--- vm-group.el	Sat Jan 11 01:03:07 1992
***************
*** 45,51 ****
  (defconst vm-group-by-subject-closure (cons t t))
  
  (defun vm-group-by-subject (m1 m2)
!   (let ((subject (vm-su-subject m1)))
      (if (eq subject (car vm-group-by-subject-closure))
  	(setq subject (cdr vm-group-by-subject-closure))
        (setcar vm-group-by-subject-closure subject)
--- 45,52 ----
  (defconst vm-group-by-subject-closure (cons t t))
  
  (defun vm-group-by-subject (m1 m2)
!   (let ((subject (vm-su-subject m1))
! 	(case-fold-search t))
      (if (eq subject (car vm-group-by-subject-closure))
  	(setq subject (cdr vm-group-by-subject-closure))
        (setcar vm-group-by-subject-closure subject)
*** vm-delete..el	Thu Mar 28 09:46:12 1991
--- vm-delete.el	Sat Jan 11 01:01:42 1992
***************
*** 86,91 ****
--- 86,92 ----
    (vm-error-if-folder-read-only)
    (vm-error-if-folder-empty)
    (let ((subject (vm-su-subject (car vm-message-pointer)))
+ 	(case-fold-search t)
  	(mp vm-message-list)
  	(n 0))
      (if (string-match "^\\(re: *\\)+" subject)
*** vm-summary..el	Mon Mar 25 00:39:43 1991
--- vm-summary.el	Sat Jan 11 01:34:25 1992
***************
*** 293,299 ****
      (put format-variable 'vm-compiled-format format)))
  
  (defun vm-get-header-contents (message header-name)
!   (let (contents regexp)
      (setq regexp (format vm-header-regexp-format header-name))
      (save-excursion
        (set-buffer (marker-buffer (vm-start-of message)))
--- 293,300 ----
      (put format-variable 'vm-compiled-format format)))
  
  (defun vm-get-header-contents (message header-name)
!   (let ((case-fold-search t)
! 	contents regexp)
      (setq regexp (format vm-header-regexp-format header-name))
      (save-excursion
        (set-buffer (marker-buffer (vm-start-of message)))
***************
*** 401,407 ****
  	    (buffer-substring (match-beginning 1) (match-end 1)))))))
  
  (defun vm-su-do-date (m)
!   (let (date)
      (setq date (or (vm-get-header-contents m "Date") (vm-grok-From_-date m)))
      (cond
       ((null date)
--- 402,408 ----
  	    (buffer-substring (match-beginning 1) (match-end 1)))))))
  
  (defun vm-su-do-date (m)
!   (let (date (case-fold-search t))
      (setq date (or (vm-get-header-contents m "Date") (vm-grok-From_-date m)))
      (cond
       ((null date)