🚀 go-pugleaf

>>> On 9 Apr 91 14:30:24 GMT,
>>> "David" == davide%cadillac.cad.mcc.com@mcc.com (David Eckelkamp) writes:

David> In VM-5.31(beta) I think there is a problem with vm-do-reply.  I
David> believe there needs to be another hook akin to mail-setup-hook because
David> VM sets some keys in the local map *after* vm-mail-internal runs the
David> mail-setup-hook.  This keeps me from being able to rebind \C-c\C-c and
David> such.  This new hook should probably be run after the 
David> "(if include-text ...)" form, IMHO.

    I _also_ wanted to change some of the key-bindings in mail-mode (in
  particular, binding C-c C-s to mail-signature), and found that VM was
  messing them up.  The problem is in vm-reply.el, where the key-rebinding
  code is duplicated in five places (not just in vm-do-reply, but also in
  vm-forward-message, vm-mail, vm-resend-bounced-message and
  vm-send-digest).  Each time it's done *after* mail-setup-hook is run
  (mail-setup-hook is called in vm-mail-internal). 

    My solution was pull the duplicated key-binding code into
  vm-mail-internal, before the call to mail-setup-hook.  Thus,
  mail-setup-hook can contain your own key redefinitions (which isn't
  strictly the right place for them, but it works). 

  [ Kyle, is there any chance of including this patch in the next release?
    I'm pretty sure it doesn't break anything. ]

  Patch (to VM 5.31b) follows ...

--- CUT HERE --------------------------------------------------------------
*** vm-reply.el-dist	Wed Apr  3 08:29:13 1991
--- vm-reply.el	Wed Apr  3 08:36:19 1991
***************
*** 103,114 ****
         (format "reply to %s%s" (vm-su-full-name (car mlist))
  	       (if (cdr mlist) ", ..." ""))
         to subject in-reply-to cc references newsgroups)
-       (use-local-map (copy-keymap (current-local-map)))
-       (local-set-key "\C-c\C-y" 'vm-yank-message)
-       (local-set-key "\C-cy" 'vm-yank-message-other-folder)
-       (local-set-key "\C-c\C-s" 'vm-mail-send)
-       (local-set-key "\C-c\C-c" 'vm-mail-send-and-exit)
-       (local-set-key "\C-c\C-v" vm-mode-map)
        (make-local-variable 'vm-reply-list)
        (setq vm-mail-buffer mail-buffer
  	    vm-system-state 'replying
--- 103,108 ----
***************
*** 413,424 ****
  	 (and vm-forwarding-subject-format
  	      (vm-sprintf 'vm-forwarding-subject-format
  			  (car mp))))
- 	(use-local-map (copy-keymap (current-local-map)))
- 	(local-set-key "\C-c\C-y" 'vm-yank-message)
- 	(local-set-key "\C-cy" 'vm-yank-message-other-folder)
- 	(local-set-key "\C-c\C-s" 'vm-mail-send)
- 	(local-set-key "\C-c\C-c" 'vm-mail-send-and-exit)
- 	(local-set-key "\C-c\C-v" vm-mode-map)
  	(make-local-variable 'vm-forward-list)
  	(setq vm-mail-buffer b
  	      vm-system-state 'forwarding
--- 407,412 ----
***************
*** 451,465 ****
    (let ((mail-buffer (if (memq major-mode '(vm-mode vm-virtual-mode))
  			 (current-buffer))))
      (vm-mail-internal)
!     (if (null mail-buffer)
! 	()
!       (use-local-map (copy-keymap (current-local-map)))
!       (local-set-key "\C-c\C-y" 'vm-yank-message)
!       (local-set-key "\C-c\C-v" vm-mode-map)
!       (setq vm-mail-buffer mail-buffer))
!     (local-set-key "\C-c\C-s" 'vm-mail-send)
!     (local-set-key "\C-c\C-c" 'vm-mail-send-and-exit)
!     (local-set-key "\C-cy" 'vm-yank-message-other-folder)))
  
  (defun vm-mail-internal
       (&optional buffer-name to subject in-reply-to cc references newsgroups)
--- 439,445 ----
    (let ((mail-buffer (if (memq major-mode '(vm-mode vm-virtual-mode))
  			 (current-buffer))))
      (vm-mail-internal)
!     (if mail-buffer (setq vm-mail-buffer mail-buffer))))
  
  (defun vm-mail-internal
       (&optional buffer-name to subject in-reply-to cc references newsgroups)
***************
*** 489,494 ****
--- 469,481 ----
        (goto-char (point-max))
      (goto-char (point-min))
      (end-of-line))
+   (if (and (boundp 'mail-buffer) (null mail-buffer)) nil
+     (use-local-map (copy-keymap (current-local-map)))
+     (local-set-key "\C-c\C-y" 'vm-yank-message)
+     (local-set-key "\C-cy" 'vm-yank-message-other-folder))
+   (local-set-key "\C-c\C-s" 'vm-mail-send)
+   (local-set-key "\C-c\C-c" 'vm-mail-send-and-exit)
+   (local-set-key "\C-c\C-v" vm-mode-map)
    (run-hooks 'mail-setup-hook))
  
  (defun vm-resend-bounced-message ()
***************
*** 530,541 ****
  	(vm-mail-internal
  	 (format "retry of %s:%s" (buffer-name)
  		 (vm-number-of (car vm-message-pointer))))
- 	(use-local-map (copy-keymap (current-local-map)))
- 	(local-set-key "\C-c\C-y" 'vm-yank-message)
- 	(local-set-key "\C-cy" 'vm-yank-message-other-folder)
- 	(local-set-key "\C-c\C-s" 'vm-mail-send)
- 	(local-set-key "\C-c\C-c" 'vm-mail-send-and-exit)
- 	(local-set-key "\C-c\C-v" vm-mode-map)
  	(goto-char (point-min))
  	(insert-buffer-substring b start lim)
  	(delete-region (point) (point-max))
--- 517,522 ----
***************
*** 658,669 ****
      (save-restriction
        (widen)
        (vm-mail-internal (format "digest from %s" (buffer-name)))
-       (use-local-map (copy-keymap (current-local-map)))
-       (local-set-key "\C-c\C-y" 'vm-yank-message)
-       (local-set-key "\C-cy" 'vm-yank-message-other-folder)
-       (local-set-key "\C-c\C-s" 'vm-mail-send)
-       (local-set-key "\C-c\C-c" 'vm-mail-send-and-exit)
-       (local-set-key "\C-c\C-v" vm-mode-map)
        (make-local-variable 'vm-forward-list)
        (setq vm-mail-buffer b
  	    vm-message-pointer mp
--- 639,644 ----
--
    /-------------------- mike-w@cs.aukuni.ac.nz ---------------------\
    | Mike Williams, Computer Science, Auckland University, Aotearoa. |
    \-------------- What's another word for Thesaurus? ---------------/
-- 
New administrater uofa.