🚀 go-pugleaf

RetroBBS NetNews Server

Inspired by RockSolid Light RIP Retro Guy

Article View: gnu.emacs.vm.bug
Article #9721

VM 5.25 -> 5.26 patch: message presentation order still not retained

#9721
From: Kyle Jones
Date: Wed, 06 Mar 1991 17:14
32 lines
1661 bytes
Gilbert Harman writes:
 > Further investigation indicates that the problem occurs only
 > when I move a message to the end.  The presentation order is
 > saved if I haven't done that.

It turns out the order wasn't saved if the current message was last
message in the pointer.  This is because I put vm-message-pointer in a
conditional where I meant vm-message-list.  Turns out I needed to fix
the 5.24 bugs before anyone would notice this one.  And so it goes...
Fixed in 5.27.

Here's the patch for those who want immediate gratification:

*** vm.el.dist	Wed Mar  6 00:05:15 1991
--- vm.el	Wed Mar  6 12:03:45 1991
***************
*** 940,946 ****
  ;; Insert a header into the first message of the folder that lists
  ;; the folder's message order.
  (defun vm-stuff-message-order ()
!   (if (cdr vm-message-pointer)
        (save-excursion
  	(vm-save-restriction
  	 (widen)
--- 940,946 ----
  ;; Insert a header into the first message of the folder that lists
  ;; the folder's message order.
  (defun vm-stuff-message-order ()
!   (if (cdr vm-message-list)
        (save-excursion
  	(vm-save-restriction
  	 (widen)
Technical Details
Message-ID: <9103061714.AA00637@wendy-fate.UU.NET>
Path: arc1-ca.pugleaf.net!gmdzi!unido!mcsun!uunet!wendy-fate.uu.net!bug-vm

Show Full Headers
Complete Article Headers
X-Google-Language: ENGLISH,ASCII-7-bit
X-Google-Thread: f6829,f7a75e74b81da6f5
X-Google-Attributes: gidf6829,public
X-Google-ArrivalTime: 1991-03-07 03:00:15 PST
Path: arc1-ca.pugleaf.net!gmdzi!unido!mcsun!uunet!wendy-fate.uu.net!bug-vm
From: kyle@wendy-fate.uu.net (Kyle Jones)
Newsgroups: gnu.emacs.vm.bug
Subject: VM 5.25 -> 5.26 patch: message presentation order still not retained
Message-ID: <9103061714.AA00637@wendy-fate.UU.NET>
Date: 6 Mar 91 17:14:38 GMT
Sender: bug-vm-request@uunet.uu.net
Lines: 32