🚀 go-pugleaf

RetroBBS NetNews Server

Inspired by RockSolid Light RIP Retro Guy

Article View: gnu.epoch.misc
Article #1729

bug in startup.el

#1729
From: Martin Boyer
Date: Tue, 08 Oct 1991 15:36
52 lines
2408 bytes
In both versions 3.2 and 4.0 of Epoch the definition of
normal-top-level in startup.el seems buggy, although it may be
difficult to trigger the bug.  The problem is that only the first form
is protected by an unwind-protect.  The following should be changed
from:

(defun normal-top-level ()
  (if command-line-processed
      (message "Back to top level.")
    (setq command-line-processed t)
    ;; In presence of symlinks, switch to cleaner form of default directory.
    (if (and (not (eq system-type 'vax-vms))
	     (getenv "PWD"))
	(setq default-directory (file-name-as-directory (getenv "PWD"))))
    (unwind-protect
      (if (boundp 'epoch::version)
	(run-hooks 'epoch-setup-hook)
      )
	(command-line)
      (and term-setup-hook
	   (funcall term-setup-hook))
      (and window-setup-hook
	   (funcall window-setup-hook)))))

to:

(defun normal-top-level ()
  (if command-line-processed
      (message "Back to top level.")
    (setq command-line-processed t)
    ;; In presence of symlinks, switch to cleaner form of default directory.
    (if (and (not (eq system-type 'vax-vms))
	     (getenv "PWD"))
	(setq default-directory (file-name-as-directory (getenv "PWD"))))
    (unwind-protect
	(progn
	  (if (boundp 'epoch::version)
	      (run-hooks 'epoch-setup-hook))
	  (command-line))
      (and term-setup-hook
	   (funcall term-setup-hook))
      (and window-setup-hook
	   (funcall window-setup-hook)))))

Note the PROGN that encloses the calls to epoch-setup-hook and
command-line.

--
Martin Boyer                            mboyer@ireq-robot.hydro.qc.ca
Institut de recherche d'Hydro-Quebec    mboyer@ireq-robot.uucp
Varennes, QC, Canada   J3X 1S1
+1 514 652-8412
Technical Details
Message-ID: <GAMIN.91Oct8113641@pellan.ireq-robot.hydro.qc.ca>
Path: arc1-ca.pugleaf.net!gmdzi!unido!mcsun!news.funet.fi!sunic!psinntp!psinntp!rpi!news-server.csri.toronto.edu!bonnie.concordia.ca!s3!s3.ireq.hydro.qc.ca!gamin

Show Full Headers
Complete Article Headers
X-Google-Language: ENGLISH,ASCII-7-bit
X-Google-Thread: fc7ee,4e5e712ce9b9e24b,start
X-Google-Attributes: gidfc7ee,public
X-Google-ArrivalTime: 1991-10-08 14:17:50 PST
Path: arc1-ca.pugleaf.net!gmdzi!unido!mcsun!news.funet.fi!sunic!psinntp!psinntp!rpi!news-server.csri.toronto.edu!bonnie.concordia.ca!s3!s3.ireq.hydro.qc.ca!gamin
From: gamin@ireq-robot.hydro.qc.ca (Martin Boyer)
Newsgroups: gnu.epoch.misc
Subject: bug in startup.el
Message-ID: <GAMIN.91Oct8113641@pellan.ireq-robot.hydro.qc.ca>
Date: 8 Oct 91 15:36:41 GMT
Sender: usenet@s3.ireq.hydro.qc.ca
Distribution: gnu
Organization: Le laboratoire de robotique de l'Institut de recherche
 d'Hydro-Quebec
Lines: 52