Thread View: gnu.epoch.misc
2 messages
2 total messages
Started by Hinrich Eilts
Thu, 04 Feb 1993 16:10
Bug in compiling epoch-4.2 with gcc-2.3.3
Author: Hinrich Eilts
Date: Thu, 04 Feb 1993 16:10
Date: Thu, 04 Feb 1993 16:10
19 lines
1694 bytes
1694 bytes
I found a bug in compiling epoch-4.2/src/filelock.c with gcc-2.3.3 on a
NeXT:
In lisp.h is a redefinition of the macro NULL (what a bad idea!), but in the
later (over a include-chan started by #include <errno.h>) included
/usr/local/lib/gcc-lib/next/2.3.3/include/stddef.h this will be overruled
by a new define of NULL (to it's usual value).
One of the affected sourcecodelines (line 118) in filelock.c looks like:
if (!NULL (subject_buf)
before preprocessing, and after the wrong turn:
if (!((void *)0) (subject_buf)
and it should be:
if (! ((subject_buf) == (Qnil) )
My propositions are: Change of the redifined NULL in epoch to EPOCH_NULL or
whatever and a warning-message from gnu-cpp for any redefinitions.
--
Bye | G i b D O S |
Hinrich Eilts | k e i n e |
(e-mail: eilts@late.e-technik.uni-erlangen.de) | C h a n c e ! |
Re: Bug in compiling epoch-4.2 with gcc-2.3.3
Author: Mike D. Kail
Date: Sun, 14 Feb 1993 17:02
Date: Sun, 14 Feb 1993 17:02
36 lines
2696 bytes
2696 bytes
In article <gnusenet-1krf5mEigf@uni-erlangen.de>, eilts@late.e-technik.uni-erlangen.de (Hinrich Eilts) writes: |> I found a bug in compiling epoch-4.2/src/filelock.c with gcc-2.3.3 on a |> NeXT: |> In lisp.h is a redefinition of the macro NULL (what a bad idea!), but in the |> later (over a include-chan started by #include <errno.h>) included |> /usr/local/lib/gcc-lib/next/2.3.3/include/stddef.h this will be overruled |> by a new define of NULL (to it's usual value). |> One of the affected sourcecodelines (line 118) in filelock.c looks like: |> if (!NULL (subject_buf) |> before preprocessing, and after the wrong turn: |> if (!((void *)0) (subject_buf) |> and it should be: |> if (! ((subject_buf) == (Qnil) ) |> My propositions are: Change of the redifined NULL in epoch to EPOCH_NULL or |> whatever and a warning-message from gnu-cpp for any redefinitions. |> |> -- |> Bye | G i b D O S | |> Hinrich Eilts | k e i n e | |> (e-mail: eilts@late.e-technik.uni-erlangen.de) | C h a n c e ! | |> I got around this annoying problem by using sed to replace the NULL with NIL, which is #define'd to be the same as NULL. I agree though, the use of NULL was not a well-thought-out decision. -- +---------------------------------------------------------------+ | Mike D. Kail mdk@pegasus.udev.cdc.com | | Control Data Systems, Inc. | | 4201 North Lexington Avenue (612) 482-2942 (W) | | Arden Hills, MN 55126 (612) 628-9132 (H) | +---------------------------------------------------------------+ | "Nothing great was ever achieved without enthusiasm." | | - Ralph Waldo Emerson | +---------------------------------------------------------------+
Thread Navigation
This is a paginated view of messages in the thread with full content displayed inline.
Messages are displayed in chronological order, with the original post highlighted in green.
Use pagination controls to navigate through all messages in large threads.
Back to All Threads