epoch.el sets global target-buffer

Thread View: gnu.epoch.misc

1 messages

[T] Back to Threads [V] Tree View [G] Group Articles

1 total messages Started by Eric Eide Fri, 13 Nov 1992 16:49

#366

Author: Eric Eide
Date: Fri, 13 Nov 1992 16:49

29 lines
1563 bytes

What a strange subject, eh?  What I'm trying to say is that several of the
functions in Epoch 4.2's "epoch.el" set the global variable "target-buffer"
without any apparent need:

  (defun find-file-other-screen (filename)
    "Find file in other screen"
    (interactive "FFind file other screen: ")
    (setq target-buffer (find-file-noselect filename))
    (if (bufferp target-buffer) (find-buffer-other-screen target-buffer))
  )

This looks like sloppy coding (IMHO); the offending functions should just make
a binding for target-buffer as needed:

  (defun find-file-other-screen (filename)
    "Find file in other screen"
    (interactive "FFind file other screen: ")
    (let ((target-buffer (find-file-noselect filename)))
      (if (bufferp target-buffer)
          (find-buffer-other-screen target-buffer))
      ))

Perhaps there's something I'm not seeing, or perhaps this is just historical
accident.

--
-------------------------------------------------------------------------------
Eric Eide          |          University of Utah Department of Computer Science
eeide@cs.utah.edu  | Buddhist to hot dog vendor: "Make me one with everything."

Thread Navigation

This is a paginated view of messages in the thread with full content displayed inline.

Messages are displayed in chronological order, with the original post highlighted in green.

Use pagination controls to navigate through all messages in large threads.

Back to All Threads