Bug in epoch::read-pixmap-file : abort()'s if it's not an XPM file

Thread View: gnu.epoch.misc

1 messages

[T] Back to Threads [V] Tree View [G] Group Articles

1 total messages Started by Michael Joosten Sun, 12 Apr 1992 18:35

#98

Author: Michael Joosten
Date: Sun, 12 Apr 1992 18:35

34 lines
2017 bytes

Hello, while experimenting a bit with read-pixmap-file epoch-4.0p0 will surely
aboort if you read (mistakenly) a non XPM file, like a bitmap (btw: how to
read a bitmap file?). The reason was that the 'attribute' argument wasn't
properly initialized and thus free() tried to free garbage:

diff -c button.c.bak button.c
*** button.c.bak        Sat Apr 11 22:46:23 1992
--- button.c    Sun Apr 12 17:55:03 1992
***************
*** 149,154 ****
--- 149,160 ----
    attributes.colorsymbols = symbols;
    attributes.numsymbols = 0;

+   attributes.colorTable = (char***)0;
+   attributes.hints_cmt  = (char*)0;
+   attributes.colors_cmt = (char*)0;
+   attributes.pixels_cmt = (char*)0;
+   attributes.pixels     = (Pixel*)0;
+
    BLOCK_INPUT();
    status = XpmReadFileToPixmap(XD_display,cur_Xscreen->xid,

Michael
--
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| Michael Joosten   |       Tel.  : (+49) (+) 5251-284 120                 |
| CADLAB            |       Fax   : (+49) (+) 5251-284 140                 |
| Bahnhofstr. 32    |       E-Mail: joost@cadlab.de                        |
| D-4790 Paderborn  |        	    ...!uunet!unido!cadlab!joost           | 
| FRG               | Mass mail to: joost@pbinfo.uni-paderborn.de          |
|--------------------------------------------------------------------------|
| CADLAB is a cooperation between Uni-GH Paderborn & SNI AG                |
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Thread Navigation

This is a paginated view of messages in the thread with full content displayed inline.

Messages are displayed in chronological order, with the original post highlighted in green.

Use pagination controls to navigate through all messages in large threads.

Back to All Threads