🚀 go-pugleaf

RetroBBS NetNews Server

Inspired by RockSolid Light RIP Retro Guy

Article View: gnu.g++.bug
Article #48

Patch for Bug

#48
From: Mike Tiller
Date: Wed, 04 Nov 1992 11:39
36 lines
1780 bytes
Regarding my bug report:

>This is a bug report for the gcc-2.3.1 C++ compiler.
>
>Platform:   sparc-sun-sunos4.1
>
>Summary:    The routine that builds unique names for derived classes
>            allows '<' and '>' characters to get into assembly files.
>            This only happens (as far as I know) when you are using
>            templates.  I found a way of correcting this, but it is a
>            real hack and I'm afriad it might generate non-unique names.

Here is a patch I think should be ok to fix this (temporarily).  Then
again I could be wrong, I've never patched g++ before so this could
have some serious conceptual errors.  I don't think many programs
go through this part of the code.

This patch successfully cured the problem I was having without introducing
any side-effects (that I could see).

------------Begin--------------
3292c3292
<   char *first, *base, *name, *ptr;
---
>   char *first, *base, *name;
3302,3304c3302,3303
< 
<   ptr = build_overload_name(type, 1, 1);
<   obstack_grow (&temporary_obstack, ptr, strlen(ptr));
---
>   obstack_grow (&temporary_obstack,
>               TYPE_NAME_STRING (type), TYPE_NAME_LENGTH (type));
------------End----------------

Michael Tiller
(tiller@solace.me.uiuc.edu)
Technical Details
Message-ID: <9211042339.AA14029@solace.me.uiuc.edu>
Path: arc1-ca.pugleaf.net!sparky!uunet!charon.amdahl.com!pacbell.com!iggy.GW.Vitalink.COM!cs.widener.edu!umn.edu!spool.mu.edu!uwm.edu!zaphod.mps.ohio-state.edu!cis.ohio-state.edu!solace.me.uiuc.edu!tiller

Show Full Headers
Complete Article Headers
Newsgroups: gnu.g++.bug
Path: arc1-ca.pugleaf.net!sparky!uunet!charon.amdahl.com!pacbell.com!iggy.GW.Vitalink.COM!cs.widener.edu!umn.edu!spool.mu.edu!uwm.edu!zaphod.mps.ohio-state.edu!cis.ohio-state.edu!solace.me.uiuc.edu!tiller
From: tiller@solace.me.uiuc.edu (Mike Tiller)
Subject: Patch for Bug
Message-ID: <9211042339.AA14029@solace.me.uiuc.edu>
Sender: gnulists@ai.mit.edu
Organization: GNUs Not Usenet
Distribution: gnu
Date: Wed, 4 Nov 1992 11:39:04 GMT
Approved: bug-g++@prep.ai.mit.edu
Lines: 37