🚀 go-pugleaf

RetroBBS NetNews Server

Inspired by RockSolid Light RIP Retro Guy

Article View: gnu.gcc.bug
Article #1520

2.3.3 fixincludes bug+patch

#1520
From: Peter A. Bigot
Date: Sat, 02 Jan 1993 05:30
50 lines
2776 bytes
There is a bug in fixincludes which arises given a certain configuration of
/usr/include.  We have /usr/include/X11 as a symlink to
/usr/X11R5/include/X11.  /usr/X11R5/include/X11 has several subdirectories
(e.g., phigs).  fixincludes as distributed detects these subdirectories when
building the subdirectories list of /usr/include, and creates them in the
LIB directory.  However, it then proceeds to delete the entire
${LIB}/include/X11 hierarchy and replace it with a symlink to
${LIB}/include/root/usr/X11R5/include/X11.  The subdirectories that were in
$LIB/include/X11 are not recreated.  As a result, when
/usr/include/X11/phigs/phigs.h is being fixed, the copy to
$LIB/include/X11/phigs/phigs.h fails since the phigs subdirectory doesn't
exist.

The following patch makes fixincludes duplicate the subdirectory creation in
the new root area.

--- fixincludes.orig	Fri Dec  4 17:49:22 1992
+++ fixincludes	Sat Jan  2 10:31:14 1993
@@ -177,6 +177,17 @@
 	      dirname=`echo $dirname | sed -e 's|[^/]*/||'`
 	    done
 	  fi
+          # Duplicate directory structure created in ${LIB}/$file in new
+          # root area.
+          for file2 in $files; do
+            if expr ${file2} : "${file}/.*" > /dev/null ; then
+              dupdir=${LIB}/root$x/`echo $file2 | sed -n "s|^${file}/||p"`
+#              echo "Duplicating from ${file}'s ${file2} to ${dupdir}"
+              if [ ! -d ${dupdir} ] ; then
+                mkdir ${dupdir}
+                fi
+              fi
+            done
 	  rm -fr ${LIB}/$file > /dev/null 2>&1
 	  ln -s ${LIB}/root$x ${LIB}/$file > /dev/null 2>&1
 	  treetops="$treetops $x ${LIB}/root$x"

--
                     Peter A. Bigot -- pab@cs.arizona.edu
          Dept. of Computer Science, University of Arizona, Tucson AZ
---------------------------- The current quote is: ----------------------------
 "That's all for now.  This is Miss Lidia, saying: 'Bye-bye'--and remember,
		 the better you look, the more you'll see."

-- 
                     Peter A. Bigot -- pab@cs.arizona.edu
          Dept. of Computer Science, University of Arizona, Tucson AZ
---------------------------- The current quote is: ----------------------------
 "That's all for now.  This is Miss Lidia, saying: 'Bye-bye'--and remember,
		 the better you look, the more you'll see."
Technical Details
Message-ID: <199301021930.AA20889@omnia.cs.arizona.edu>
Path: arc1-ca.pugleaf.net!sparky!uunet!zaphod.mps.ohio-state.edu!cis.ohio-state.edu!cs.arizona.edu!pab

Show Full Headers
Complete Article Headers
Newsgroups: gnu.gcc.bug
Path: arc1-ca.pugleaf.net!sparky!uunet!zaphod.mps.ohio-state.edu!cis.ohio-state.edu!cs.arizona.edu!pab
From: pab@cs.arizona.edu (Peter A. Bigot)
Subject: 2.3.3 fixincludes bug+patch
Message-ID: <199301021930.AA20889@omnia.cs.arizona.edu>
Sender: gnulists@ai.mit.edu
Organization: GNUs Not Usenet
Distribution: gnu
Date: Sat, 2 Jan 1993 05:30:54 GMT
Approved: bug-gcc@prep.ai.mit.edu
Lines: 51