README.X11 (gcc 2.2.2) overzealous in optimizing some objects

Thread View: gnu.gcc.bug

1 messages

[T] Back to Threads [V] Tree View [G] Group Articles

1 total messages Started by Jim Mattson Tue, 08 Sep 1992 20:33

#1092

Author: Jim Mattson
Date: Tue, 08 Sep 1992 20:33

31 lines
1579 bytes

[Sun-4/260, SunOS 4.1.2, cg2 framebuffer, X11R5 patch level 17]

The patches included for compiling X11R5 with gcc 2.2.2 are a little
overzealous for optimizing mit/server/ddx/sun/sunCG2[CM].c.  With -O2,
a few stores to the CG2 csr get optimized out, causing colormap
brain-damage in the case of sunCG2C.c, and possibly causing some
problems with sunCG2M.c as well (though I've never tried it).

I considered adding volatile keywords to the appropriate variable
declarations, but time pressures got the best of me.  Here's an
Imakefile patch that can go in with the rest of them in README.X11.
(It compiles these two modules with -fvolatile when using gcc 2.x.)

--jim

*** 1.1 1992/09/08 19:52:07
--- mit/server/ddx/sun/Imakefile        1992/09/08 21:10:22
***************
*** 43,48 ****
--- 43,53 ----
  LinkFile(sunGX.o,sunGX.o.dist)
  #endif

+ #if HasGcc2
+ SpecialObjectRule(sunCG2C.o,sunCG2C.c,-fvolatile)
+ SpecialObjectRule(sunCG2M.o,sunCG2M.c,-fvolatile)
+ #endif
+ 
  sunInitExtMono.o: $(ICONFIGFILES)
  ObjectFromSpecialSource(sunInitExtMono,../mi/miinitext,-UPEXEXT)
  ObjectFromSpecialSource(sunInitMono,sunInit,-DMONO_ONLY)

Thread Navigation

This is a paginated view of messages in the thread with full content displayed inline.

Messages are displayed in chronological order, with the original post highlighted in green.

Use pagination controls to navigate through all messages in large threads.

Back to All Threads