🚀 go-pugleaf

I have a few comments about gcc-2.3.1 (-Wall -ansi, sunos-sun4-4.1):

o  Arrays of unbracketed struct declarations are given warnings. According
   to ANSI C, this is perfectly legal, so a warning here is unwarranted.

o  Conditionals with a single assignment are warned to surround the
   assignment with parenthesis. Since the assignment is the only expression
   in the conditional, this is overkill.

o  Fixincludes doesn't fix all the #endif's with trailing garbage from the
   headers in /usr/include. Using -Wall and -ansi we had to manually strip
   tens of headers.

The following sample shows the first two problems:

503!% cat florp.c
#include <stdio.h>

static struct
{
        int i;
        char *s;
} arr[] =
{
        1,      "hello",
        2,      "there"
};

int
main()
{
        int v;

        if (v = arr[0].i)
                printf("nonzero");
        return 0;
}
504!% gcc -Wall -ansi -c florp.c
florp.c:11: warning: aggregate has a partly bracketed initializer
florp.c:11: warning: aggregate has a partly bracketed initializer
florp.c: In function `main':
florp.c:18: warning: suggest parentheses around assignment used as truth value
florp.c:19: warning: implicit declaration of function `printf'

We use gcc -ansi -Wall as a sort of compile-time lint, and most of gcc's
warnings are well-founded. I believe the examples above could be used in
some more stringent lint behavior. Please correct me if I'm wrong (since
I'm new to the gcc bug group and discussions).

zorst
[obz@raster.Kodak.COM]
-- 
zorst (orest zborowski)
[obz@raster.Kodak.COM]