🚀 go-pugleaf

I ran into a problem with olvwm3.2 and gcc-2.2.2 on a SS2 running SunOS
4.1.1.  The following code at the end of vdmPerformAction in virtual.c
is causing problems when an offset is negative:

    deltas.delta_x = vdm->offsetX +
			((a - ACTION_GOTO_1) % vdm->columns) * dw;
    deltas.delta_y = vdm->offsetY +
			((a - ACTION_GOTO_1) / vdm->columns) * dh;

This short program demonstrates the same problem:

enum action { ACTION_GOTO_1, ACTION_GOTO_5 };

main()
{
	double x, y;
	int offsetX = -1;
	int offsetY = -1;
	int columns = 5;
	int dw = 1152;
	int dh = 900;
	enum action a = ACTION_GOTO_5;

	x = offsetX + ((a - ACTION_GOTO_1) % columns) * dw;
	y = offsetY + ((a - ACTION_GOTO_1) / columns) * dh;

	printf("x=%f y=%f\n", x, y);
}

For some reason the expression (a - ACTION_GOTO_1) is being treated
as an unsigned int.  Casting the expression to int fixes the problem,
but this doesn't seem right.

Any help would be appreciated.

--
Eric Fifer
Salomon Brothers Asia Limited
Urbannet Otemachi Bldg, 18th Fl
2-2, Otemachi 2-chome                | Internet: egf@sbi.com
Chiyoda-ku, Tokyo 100, Japan         | UUCP:     uunet!sbi!egf