🚀 go-pugleaf

In article <9005161953.AA11842@ray.sun.com> oakhill!ray!jay@CS.UTEXAS.EDU (Jay Norwood) writes:
>I'm working with 3.5 coffread.c.  In the function getfilename, there is
>a section for reading in long filenames:
>  if (aux_entry->x_file.x_foff != 0)
>    strcpy (buffer, stringtab + aux_entry->x_file.x_foff);
>---------------
>Since the first filename symbol may very well be the first symbol
>which deposits a string in the string table (if the filename is longer
>than FILNMLEN), and since the x_foff is relative to the start of the
>string table, it is very possible to have a valid long filename at the
>same time as x_foff==0.  In other words this is a very risky test.
>Wouldn't it be better to just test x_file.x_fname[0] for a 0 in order to
>determine whether or not to use x_foff?
>Jay Norwood

I'm not 100% sure, but I seem to recall that there is some rule that says
that the first byte of the coff string table is never actually used (for
this exact reason) and so the first (valid) offset must be 1.

Can somebody verify that?

// rfg