Re: [RFA] Fix file name generation in edit_command (was: Ver 6.3 edit command failing)

Article View: gnu.gdb.bug

Article #1268

#1268

From: Eli Zaretskii
Date: Thu, 28 Apr 2005 07:02

25 lines
2934 bytes

> Date: Wed, 27 Apr 2005 14:04:10 -0400
> From: Daniel Jacobowitz <drow@false.org>
> Cc: bug-gdb@rich-paul.net, bug-gdb@gnu.org, gdb-patches@sources.redhat.com
> 
> It strikes me as odd that you can use "edit" if GDB doesn't know where
> the source file is.

I thought about that, and decided to leave that code alone: GDB might
indeed not know where's the source, but the user could know more.
Most editors let you open files from inside the editor, so a user
could still edit the file.

> Also, symtab_to_fullname includes the cached fullname check.  So what's
> your opinion of boiling the whole thing down to:
> 
>   fn = symtab_to_fullname (sal.symtab);
>   if (fn == NULL)
>     error (_("Could not find file \"%s\""), sal.symtab->filename);
>   p = xstrprintf ("%s +%d %s", editor, sal.line, fn);
> 
> Mark, can I have those bonus points? :-)

Well, perhaps you should commit this, then.  There's not a single line
written by me in this snippet, so it would be misleading for me to
claim the credits in the logs.

Technical Details

Message-ID: <mailman.3269.1114671963.2895.bug-gdb@gnu.org>

Path:

arc1-ca.pugleaf.net!g2news1.google.com!news4.google.com!newshub.sdsu.edu!headwall.stanford.edu!newsfeed.stanford.edu!shelby.stanford.edu!not-for-mail

References:

<E1DLM3u-0000IQ-Vj@lists.gnu.org> <01c54b35$Blat.v2.4$c3f52520@zahav.net.il> <20050427143620.GA1686@nevyn.them.org> <01c54b40$Blat.v2.4$be3bafe0@zahav.net.il> <20050427180410.GA19592@nevyn.them.org>

Show Full Headers

Complete Article Headers

X-Google-Thread: f5053,f951753e39b033fe
X-Google-Attributes: gidf5053,public
X-Google-Language: ENGLISH,ASCII-7-bit
Path: arc1-ca.pugleaf.net!g2news1.google.com!news4.google.com!newshub.sdsu.edu!headwall.stanford.edu!newsfeed.stanford.edu!shelby.stanford.edu!not-for-mail
From: "Eli Zaretskii" <eliz@gnu.org>
Newsgroups: gnu.gdb.bug
Subject: Re: [RFA] Fix file name generation in edit_command (was: Ver 6.3
 edit command failing)
Date: Thu, 28 Apr 2005 10:02:53 +0300
Lines: 27
Sender: halo1@zahav.net.il
Approved: bug-gdb@gnu.org
Message-ID: <mailman.3269.1114671963.2895.bug-gdb@gnu.org>
References: <E1DLM3u-0000IQ-Vj@lists.gnu.org>
 <01c54b35$Blat.v2.4$c3f52520@zahav.net.il>
 <20050427143620.GA1686@nevyn.them.org>
 <01c54b40$Blat.v2.4$be3bafe0@zahav.net.il>
 <20050427180410.GA19592@nevyn.them.org>
Reply-To: Eli Zaretskii <eliz@gnu.org>
NNTP-Posting-Host: lists.gnu.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7BIT
X-Trace: news.Stanford.EDU 1114671920 21189 199.232.76.165 (28 Apr 2005 07:05:20 GMT)
X-Complaints-To: news@news.stanford.edu
To: bug-gdb@gnu.org, gdb-patches@sources.redhat.com
Envelope-to: bug-gdb@gnu.org
X-Mailer: emacs 22.0.50 (via feedmail 8 I) and Blat ver 2.4
In-reply-to: <20050427180410.GA19592@nevyn.them.org> (message from Daniel
 Jacobowitz on Wed, 27 Apr 2005 14:04:10 -0400)
X-BeenThere: bug-gdb@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Bug reports for GDB, the GNU debugger" <bug-gdb.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/bug-gdb>,
 <mailto:bug-gdb-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/bug-gdb>
List-Post: <mailto:bug-gdb@gnu.org>
List-Help: <mailto:bug-gdb-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/bug-gdb>,
 <mailto:bug-gdb-request@gnu.org?subject=subscribe>

Reply to Parent Message