🚀 go-pugleaf

I recommend testing for (m) != NULL in the ALL_MSYMBOLS macro
in objfiles.h (gdb 4.5 at least). All other macros in objefiles.h
are safe except this one.

It happened to me that I had a bad object file and that an error
occured in reading in dbx_symfile_init() and then gdb would core dump
because objfile -> msymbol is NULL.

So, it is safer to replace ALL_MSYMBOLS by the following :

#define	ALL_MSYMBOLS(objfile, m) \
  ALL_OBJFILES (objfile)	 \
    for ((m) = (objfile) -> msymbols; ((m) != NULL) && ((m)->name != NULL); (m)++)

Maybe an additional fix would be to remove this object file from the
list.

Let me know your comments.
Regards
Pierre Willard