🚀 go-pugleaf

bfd/aoutx.h (the BFD 0.18 that is distributed with GDB 4.7) has some minor
problems when setting common symbol section and flags.  These problems don't
affect correctness, but make the code hard to follow.  Two
`cache_ptr->symbol.flags = 0' assignments are useless because
cache_ptr->symbol.flags is immediately set to some other value.  Fortran
common symbols are treated first, as a special case, even though there's
nothing special about them and the extra comparison merely slows things down
for other symbols.  Here is a patch.

===================================================================
RCS file: bfd/aoutx.h,v
retrieving revision 4.7
diff -c -r4.7 bfd/aoutx.h
*** bfd/aoutx.h	1992/10/16 19:15:57	4.7
--- bfd/aoutx.h	1992/10/25 07:24:08
***************
*** 1129,1144 ****
        }
      else {
  
- 	if (sym_is_fortrancommon (cache_ptr))
- 	{
- 	  cache_ptr->symbol.flags = 0;
- 	  cache_ptr->symbol.section = &bfd_com_section;
- 	}
- 	else {
- 
- 
- 	  }
- 	  
  	/* In a.out, the value of a symbol is always relative to the 
  	 * start of the file, if this is a data symbol we'll subtract
  	 * the size of the text section to get the section relative
--- 1129,1134 ----
***************
*** 1160,1168 ****
  	    cache_ptr->symbol.value -= obj_bsssec(abfd)->vma;
  	  }
  	else  if (sym_is_undefined (cache_ptr)) {
- 	    cache_ptr->symbol.flags = 0;
  	    cache_ptr->symbol.section = &bfd_und_section;
  	  }
  	else if (sym_is_absolute(cache_ptr))
  	{
  	  cache_ptr->symbol.section = &bfd_abs_section;
--- 1150,1159 ----
  	    cache_ptr->symbol.value -= obj_bsssec(abfd)->vma;
  	  }
  	else  if (sym_is_undefined (cache_ptr)) {
  	    cache_ptr->symbol.section = &bfd_und_section;
  	  }
+ 	else if (sym_is_fortrancommon (cache_ptr))
+ 	  cache_ptr->symbol.section = &bfd_com_section;
  	else if (sym_is_absolute(cache_ptr))
  	{
  	  cache_ptr->symbol.section = &bfd_abs_section;