🚀 go-pugleaf

GDB 4.7's gdb/environ.c applies the memcpy routine to overlapping regions of
memory.  This isn't portable -- the ANSI C standard says that the results are
undefined when applying memcpy to overlapping regions.  environ.c should use
memmove instead (it's defined just for that purpose), but I suppose that
memmove is too much of a pain to configure, so here is a patch that avoids
memcpy entirely.

I reported this bug for GDB 4.6 but it wasn't fixed in GDB 4.7.
Since environ.c didn't change, the same patch works for GDB 4.7.


===================================================================
RCS file: gdb/environ.c,v
retrieving revision 4.6
diff -c -r4.6 gdb/environ.c
*** gdb/environ.c	1992/07/06 17:10:46	4.6
--- gdb/environ.c	1992/07/23 23:27:13
***************
*** 179,187 ****
  	&& s[len] == '=')
        {
  	free (s);
! 	memcpy (vector, vector + 1,
! 		(e->allocated - (vector - e->vector)) * sizeof (char *));
! 	e->vector[e->allocated - 1] = 0;
  	return;
        }
  }
--- 179,186 ----
  	&& s[len] == '=')
        {
  	free (s);
! 	while ((vector[0] = vector[1]) != NULL)
! 	  vector++;
  	return;
        }
  }