Bug in command line edit library: readline() vi_mode

Thread View: gnu.gdb.bug

1 messages

[T] Back to Threads [V] Tree View [G] Group Articles

1 total messages Started by Michael Eldredge Tue, 13 Feb 1990 22:43

#828

Author: Michael Eldredge
Date: Tue, 13 Feb 1990 22:43

26 lines
1373 bytes

 I have been using the command line edit / history library that is
 used in bash and gdb for a while.  I am a KSH vi-mode addict and
 the availability of the simple readline() routine has meant that all
 of the programs in our research group now work the same way --
 offering command line edits and history.  For those that haven't
 used it, "check it out".  [Some documentation on the programmer's
 interface would be nice.] End of commercial.

 The bug and fix are in vi_mode.c

	RCS file: RCS/vi_mode.c,v
	retrieving revision 1.1
	diff  -r1.1 vi_mode.c
	78c78
	<   p = (char *)alloca (2 + rl_prompt ? strlen (rl_prompt) : 0);
	---
	>   p = (char *)alloca (2 + (rl_prompt ? strlen (rl_prompt) : 0) );

 This caused a core dump on a Sun3 when trying a history search.
 The parens are needed to get the precedence correct.

 Hope this helps someone.

 Michael Eldredge
 Stanford IC Lab

Thread Navigation

This is a paginated view of messages in the thread with full content displayed inline.

Messages are displayed in chronological order, with the original post highlighted in green.

Use pagination controls to navigate through all messages in large threads.

Back to All Threads