🚀 go-pugleaf

RetroBBS NetNews Server

Inspired by RockSolid Light RIP Retro Guy

Article View: gnu.groff.bug
Article #24

rename comment_info.proc to comment_info.pmf

#24
From: Simon J Gerraty
Date: Tue, 07 Apr 1992 20:34
65 lines
2196 bytes
GROFF VERSION:
1.05

MACHINE:
Bull DPX/2 340

OS:
B.O.S. 2.00.45	(System V 3.1 + POSIX)

COMPILER:
gcc-2.1, libg++-2.0

INPUT FILES: ps/psrm.c

COMMAND LINE:
N/A

DESCRIPTION OF INCORRECT BEHAVIOUR:
This same compiler and library compile groff ok on sun386 and
sun4c.  On the Bull DPX/2, then name proc in struct comment_info
appears to conflict with _something_ in one of the system header
files - though I was unable to track it down.  The compilation
of ps/psrm.c fails with initialization between incompatible
pointer types.


SUGGESTED FIX:
this patch changes the name from proc to pmf

*** ps/psrm.c.~5~	Mon Apr  6 18:55:08 1992
--- ps/psrm.c	Tue Apr  7 10:16:48 1992
***************
*** 875,881 ****
  				/ sizeof(header_comment_table[0]));
    struct comment_info {
      const char *name;
!     int (resource_manager::*proc)(const char *, int, FILE *, FILE *);
    };
  
    static comment_info comment_table[] = {
--- 875,881 ----
  				/ sizeof(header_comment_table[0]));
    struct comment_info {
      const char *name;
!     int (resource_manager::*pmf)(const char *, int, FILE *, FILE *);
    };
  
    static comment_info comment_table[] = {
***************
*** 935,941 ****
  	  for (int i = 0; i < NCOMMENTS; i++)
  	    if (ptr = matches_comment(buf, comment_table[i].name)) {
  	      copy_this_line
! 		= (this->*(comment_table[i].proc))(ptr, rank, fp, outfp);
  	      break;
  	    }
  	  if (i >= NCOMMENTS && in_header) {
--- 935,941 ----
  	  for (int i = 0; i < NCOMMENTS; i++)
  	    if (ptr = matches_comment(buf, comment_table[i].name)) {
  	      copy_this_line
! 		= (this->*(comment_table[i].pmf))(ptr, rank, fp, outfp);
  	      break;
  	    }
  	  if (i >= NCOMMENTS && in_header) {
Technical Details
Message-ID: <199204070034.AA19054@taureau.melb.bull.oz.au>
Path: arc1-ca.pugleaf.net!sparky!uunet!cis.ohio-state.edu!melb.bull.oz.AU!sjg

Show Full Headers
Complete Article Headers
Newsgroups: gnu.groff.bug
Path: arc1-ca.pugleaf.net!sparky!uunet!cis.ohio-state.edu!melb.bull.oz.AU!sjg
From: sjg@melb.bull.oz.AU (Simon J Gerraty)
Subject: rename comment_info.proc to comment_info.pmf
Message-ID: <199204070034.AA19054@taureau.melb.bull.oz.au>
Sender: gnulists@ai.mit.edu
Organization: GNUs Not Usenet
Distribution: gnu
Date: Tue, 7 Apr 1992 20:34:57 GMT
Approved: bug-groff@prep.ai.mit.edu
Lines: 66