🚀 go-pugleaf

GROFF VERSION: 1.06

MACHINE: Sun Sparcstation 1

OS: SunOS 4.1.2

COMPILER: GCC 2.2.2 with local patches

INPUT FILES: none

COMMAND LINE: none

DESCRIPTION OF INCORRECT BEHAVIOUR:
groff 1.06 initializes a char variable with the value 133,
which strictly speaking isn't allowed on systems with signed chars,
where legal chars are in the range -128..127.

SUGGESTED FIX:
===================================================================
RCS file: troff/input.cc,v
retrieving revision 1.6
diff -c1 -r1.6 troff/input.cc
*** troff/input.cc	1992/08/25 15:02:53	1.6
--- troff/input.cc	1992/09/02 09:04:53
***************
*** 134,136 ****
  const int ESCAPE_E = 0204;
! const int LAST_PAGE_EJECTOR = 0205;
  const int ESCAPE_RIGHT_PARENTHESIS = 0206;
--- 134,137 ----
  const int ESCAPE_E = 0204;
! const char LAST_PAGE_EJECTOR_char = '\205'; // to avoid initialization overflow
! const int LAST_PAGE_EJECTOR = (unsigned char) LAST_PAGE_EJECTOR_char;
  const int ESCAPE_RIGHT_PARENTHESIS = 0206;
***************
*** 1810,1812 ****
    topdiv->set_ejecting();
!   static char buf[2] = { LAST_PAGE_EJECTOR, '\0' };
    input_stack::push(make_temp_iterator(buf));
--- 1811,1813 ----
    topdiv->set_ejecting();
!   static char buf[2] = { LAST_PAGE_EJECTOR_char, '\0' };
    input_stack::push(make_temp_iterator(buf));