🚀 go-pugleaf

getdate.y in fileutils 3.4 and shellutils 1.8 still doesn't compile an
IBM RT running AOS (4.3BSD) with gcc 2.3.1.  The problem is unchanged
from the last release getdate.y was in (tar 1.11.1, I think): <time.h>
is included twice, once by virtue of the #include <sys/time.h> (which in
turn includes <time.h>) around line 40 of getdate.y:

#if !defined (USG) && !defined (sgi) && !defined (__386BSD__)
#include <sys/time.h>
#endif

and again by virtue of the #include <time.h> around line 76:

#if	defined(BSD4_2) || defined(BSD4_1C) || (defined (hp9000) && !defined (hpux))
#include <sys/time.h>
#else
#if defined(_AIX)
#include <sys/time.h>
#endif
#include <time.h>
#endif	/* defined(BSD4_2) */


More generally, the problem is that Autoconf does not define symbols
like BSD4_2 or BSD4_1C (in this case, defining BSD4_2 solves the
problem, since <sys/time.h> is protected against multiple inclusion).
Personally, I think those ``system macros'' like BSD4_2 are doomed to
failure; I don't know what feature getdate.y is trying to include in
those lines, but whatever it is, surely it would be better to test for
it specifically.