Patch 2.0 12g8 bug

Article View: gnu.utils.bug

Article #1358

#1358

From: Bob Glickstein
Date: Wed, 27 Jan 1993 03:26

26 lines
1147 bytes

In get_some_switches() in patch.c, the result of getopt_long() is
assigned to a char, then compared (with `!=') to -1.  This always
succeeds on machines where chars are unsigned.

Apply this patch to patch:

--- patch.c.orig	Tue Jan 26 17:02:55 1993
+++ patch.c	Tue Jan 26 17:03:41 1993
@@ -474,7 +474,7 @@
 void
 get_some_switches()
 {
-    Reg1 char optc;
+    Reg1 int optc;
 
     rejname[0] = '\0';
     optind_last = optind;

Cheers.

-- 
Bob Glickstein
Z-Code Software Corp.
4340 Redwood Highway  Suite B-50
San Rafael, CA  94903
(415) 499-8649

Technical Details

Message-ID: <9301261710.ZM5878@zindigo.z-code.com>

Path:

arc1-ca.pugleaf.net!sparky!uunet!stanford.edu!ames!sun-barr!cs.utexas.edu!swrinde!zaphod.mps.ohio-state.edu!pacific.mps.ohio-state.edu!cis.ohio-state.edu!zindigo.z-code.COM!bobg

Show Full Headers

Complete Article Headers

Path: arc1-ca.pugleaf.net!sparky!uunet!stanford.edu!ames!sun-barr!cs.utexas.edu!swrinde!zaphod.mps.ohio-state.edu!pacific.mps.ohio-state.edu!cis.ohio-state.edu!zindigo.z-code.COM!bobg
From: bobg@zindigo.z-code.COM (Bob Glickstein)
Newsgroups: gnu.utils.bug
Subject: Patch 2.0 12g8 bug
Date: 26 Jan 1993 22:26:17 -0500
Organization: Z-Code Software Corp., Marin County, CA
Lines: 28
Sender: daemon@cis.ohio-state.edu
Approved: bug-gnu-utils@prep.ai.mit.edu
Distribution: gnu
Message-ID: <9301261710.ZM5878@zindigo.z-code.com>
Reply-To: Bob Glickstein <bobg@z-code.z-code.com>