🚀 go-pugleaf

RetroBBS NetNews Server

Inspired by RockSolid Light RIP Retro Guy

Article View: gnu.utils.bug
Article #1427

make-3.26 bug

#1427
From: Dirk Grunwald
Date: Mon, 12 Dec 1988 19:11
38 lines
1595 bytes
This is for gnumake-3.26. I previously posted the wrong patch.

re: patch to get parallel make to work

The problem is the following:
         
        + in decode_switches, you call decode_env_switches. So far so good.
        + after decode_switched, you call  new_environ () 
 
          this builds MAKEFLAGS and MFLAGS from the command line switches.

          however, if the parameter is a positive_int && == 'j' (i.e. -j) 
          then MFLAGS is set to -j 1

This has the advantage that it doesn't pass the parallel-ism to the child,
however....

	+ decode_env_switches is called again

Now that MFLAGS has ``-j 1'' in it, job_slots of over-written, being set
back to 1.

The fix I did is to just remove this check & to pass the -j value for the
current value of job_slots. However, to keep the previous meaning,
perhaps the check should first insure that job_slots has the default value
before resetting it to the default value?

I'm not certain what the intent was. Roland?

Dirk Grunwald
Univ. of Illinois
grunwald@m.cs.uiuc.edu

--
Dirk Grunwald
Univ. of Illinois
grunwald@m.cs.uiuc.edu
Technical Details
Message-ID: <GRUNWALD.88Dec12131125@guitar.cs.uiuc.edu.cs.uiuc.edu>
Path: arc1-ca.pugleaf.net!utzoo!utgpu!watmath!uunet!tut.cis.ohio-state.edu!mailrus!rutgers!deimos!uxc!garcon!garcon.cso.uiuc.edu!grunwald

Show Full Headers
Complete Article Headers
Path: arc1-ca.pugleaf.net!utzoo!utgpu!watmath!uunet!tut.cis.ohio-state.edu!mailrus!rutgers!deimos!uxc!garcon!garcon.cso.uiuc.edu!grunwald
From: grunwald@guitar.cs.uiuc.edu.cs.uiuc.edu (Dirk Grunwald)
Newsgroups: gnu.utils.bug
Subject: make-3.26 bug
Message-ID: <GRUNWALD.88Dec12131125@guitar.cs.uiuc.edu.cs.uiuc.edu>
Date: 12 Dec 88 19:11:25 GMT
Sender: news@garcon.cso.uiuc.edu
Distribution: gnu
Organization: University of Illinois, Urbana-Champaign
Lines: 38