🚀 go-pugleaf

RetroBBS NetNews Server

Inspired by RockSolid Light RIP Retro Guy

Article View: gnu.utils.bug
Article #1676

Minor glitch in Makefile

#1676
From: Bennett Todd
Date: Tue, 19 Dec 1989 15:29
44 lines
1849 bytes
The Makefile from this tar off of prep:

-rw-r--r--  1 14910      250959 Nov  6 18:08 binutils.tar.Z

has a buggy make install section. There should either be a comment
pointing out you need to go "make ... bindir=/usr/local/bin" or there
should be a define for bindir in the Makefile. In the make install
section:

install: $(PROGS)
	for file in $(PROGS); do \
	cp $$file $(bindir)/$${file}.new \
	mv $(bindir)/$${file}.new $(bindir)/$file \
	done

We need to add another "$" to the last variable substitution in the "mv"
line, like so:
	mv $(bindir)/$${file}.new $(bindir)/$$file \

And finally, when I tried it, I got an error:

Script started on Tue Dec 19 10:27:38 1989
george[1] make install bindir=/usr/local/bin
for file in gprof ld size nm strip ar ranlib; do \
cp $file /usr/local/bin/${file}.new \
mv /usr/local/bin/${file}.new /usr/local/bin/$file \
done
/bin/sh: syntax error at line 1: `end of file' unexpected
make: *** [install] Error 2
george[2] 

script done on Tue Dec 19 10:27:49 1989

I dunno what's wrong. The make in question is GNU Make 3.57, built with
gcc 1.36. System is Sun 3/280 running SunOS 3.5.

Also, I don't know if this has already been reported; I was subscribed
to bug-gnu-utils for a while, but after a short flurry of messages I
seem to have been dropped from the list.

If anyone wanted to be so kind as to add me back on, I'd appreciate it.

-Bennett
bet@orion.mc.duke.edu
Technical Details
Message-ID: <8912191529.AA12405@orion>
Path: arc1-ca.pugleaf.net!utzoo!utgpu!jarvis.csri.toronto.edu!clyde.concordia.ca!uunet!tut.cis.ohio-state.edu!ORION.MC.DUKE.EDU!bet

Show Full Headers
Complete Article Headers
Path: arc1-ca.pugleaf.net!utzoo!utgpu!jarvis.csri.toronto.edu!clyde.concordia.ca!uunet!tut.cis.ohio-state.edu!ORION.MC.DUKE.EDU!bet
From: bet@ORION.MC.DUKE.EDU (Bennett Todd)
Newsgroups: gnu.utils.bug
Subject: Minor glitch in Makefile
Message-ID: <8912191529.AA12405@orion>
Date: 19 Dec 89 15:29:46 GMT
Sender: daemon@tut.cis.ohio-state.edu
Distribution: gnu
Organization: GNUs Not Usenet
Lines: 44