Article View: gnu.utils.bug
Article #363Re: Bug in make 3.54
From: Antti Louko
Date: Mon, 14 Aug 1989 14:07
Date: Mon, 14 Aug 1989 14:07
33 lines
1560 bytes
1560 bytes
In article <24351@santra.UUCP> alo@kampi.hut.fi (Antti Louko) writes:
>There was a bug in remake.c which caused make not to find -llibs under
>VPATH directories. make incorrectly tried to find /-starting name
>unfer VPATH directories.
This is just in case if my cancel didn't get through. The fix I gave
was wrong. I am sorry. I checked later at ai.mit.edu and it was
already fixed there. The correct fix is:
*** /tmp/,RCSt1011723 Mon Aug 14 17:00:36 1989
--- remake.c Mon Aug 14 17:00:15 1989
***************
*** 707,713 ****
mtime = name_mtime (name + 8);
if (mtime == (time_t) -1)
{
! char *newname = name;
if (vpath_search (&newname))
{
mtime = name_mtime (newname);
--- 707,713 ----
mtime = name_mtime (name + 8);
if (mtime == (time_t) -1)
{
! char *newname = name + 9;
if (vpath_search (&newname))
{
mtime = name_mtime (newname);
I was fooled because I thought that vpath_search might do realloc for
newname but it doesn't do that.
Antti
Technical Details
Message-ID:
<24353@santra.UUCP>Path:
arc1-ca.pugleaf.net!utzoo!utgpu!jarvis.csri.toronto.edu!rutgers!shelby!agate!ucbvax!tut.cis.ohio-state.edu!cica!ctrsol!ginosko!uunet!mcvax!sunic!kth!draken!tut!santra!kampi.hut.fi!aloReferences:
<24351@santra.UUCP>Show Full Headers
Complete Article Headers
Path: arc1-ca.pugleaf.net!utzoo!utgpu!jarvis.csri.toronto.edu!rutgers!shelby!agate!ucbvax!tut.cis.ohio-state.edu!cica!ctrsol!ginosko!uunet!mcvax!sunic!kth!draken!tut!santra!kampi.hut.fi!alo From: alo@kampi.hut.fi (Antti Louko) Newsgroups: gnu.utils.bug Subject: Re: Bug in make 3.54 Message-ID: <24353@santra.UUCP> Date: 14 Aug 89 14:07:59 GMT References: <24351@santra.UUCP> Sender: news@santra.UUCP Reply-To: alo@kampi.hut.fi (Antti Louko) Organization: Helsinki University of Technology, Finland Lines: 33