🚀 go-pugleaf

RetroBBS NetNews Server

Inspired by RockSolid Light RIP Retro Guy

Article View: gnu.utils.bug
Article #408

Bug in GNU make 3.55

#408
From: Karl Fox
Date: Thu, 07 Sep 1989 17:41
28 lines
1393 bytes
GNU Make version 3.55 (gotten from osu-cis) doesn't expand $(@D)
correctly -- it trims off the last character of the directory name. 
This fixes it:

*** commands.c.ORIG	Thu Sep  7 11:47:18 1989
--- commands.c	Thu Sep  7 12:56:51 1989
***************
*** 134,140 ****
  #define	LASTSLASH(s)	rindex ((s), '/')
  #define	FILEONLY(s)	(p != 0 ? p + 1 : (s))
  #define	DIRONLY(s)	(p == 0 ? "./" : p == (s) ? "/" \
! 			 : savestring ((s), p - (s) - 1))
  
    /* $* is the stem from an implicit or static pattern rule.  */
    if (file->stem == 0)
--- 134,140 ----
  #define	LASTSLASH(s)	rindex ((s), '/')
  #define	FILEONLY(s)	(p != 0 ? p + 1 : (s))
  #define	DIRONLY(s)	(p == 0 ? "./" : p == (s) ? "/" \
! 			 : savestring ((s), p - (s)))
  
    /* $* is the stem from an implicit or static pattern rule.  */
    if (file->stem == 0)

Version 3.54 had the same problem.  Version 3.48 had a "+ 1", which
kept the trailing slash.
-- 
Karl Fox, Morning Star Technologies               karl@MorningStar.COM
Technical Details
Message-ID: <1989Sep7.174134.24369@MorningStar.COM>
Path: arc1-ca.pugleaf.net!utzoo!utgpu!jarvis.csri.toronto.edu!rutgers!ucsd!ucbvax!tut.cis.ohio-state.edu!mstar!karl

Show Full Headers
Complete Article Headers
Path: arc1-ca.pugleaf.net!utzoo!utgpu!jarvis.csri.toronto.edu!rutgers!ucsd!ucbvax!tut.cis.ohio-state.edu!mstar!karl
From: karl@MorningStar.COM (Karl Fox)
Newsgroups: gnu.utils.bug
Subject: Bug in GNU make 3.55
Message-ID: <1989Sep7.174134.24369@MorningStar.COM>
Date: 7 Sep 89 17:41:34 GMT
Distribution: gnu
Organization: Morning Star Technologies, Columbus, Ohio
Lines: 28